feat(laravel): auto configure our tagged interfaces #7014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
soyuka
commented
Mar 12, 2025
soyuka
commented
| Q | A |
|---|---|
| Branch? | 4.1 (feature is available inside symfony) |
| License | MIT |
| Doc PR | needs to be done |
soyuka
force-pushed
the
feat/laravel-autoconfigure
branch
from
6b5527d to
44468ca
Compare
soyuka
force-pushed
the
feat/laravel-autoconfigure
branch
from
44468ca to
a075d1d
Compare
flug
reviewed
Mar 12, 2025
| private function tagServices(): void | ||
| { | ||
| $directory = app_path(); | ||
| $classes = ReflectionClassRecursiveIterator::getReflectionClassesFromDirectories([$directory]); |
There was a problem hiding this comment.
don't you think we should serialize or cache the tree to avoid possible performance problems?
There was a problem hiding this comment.
ReflectionClassRecursiveIterator has already a memory cache and in the Provider we can't use the cache yet as it's not properly booted...
Note that this will only fetch classes from the app directory so the impact shouldn't be that huge.
dunglas
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.