Skip to content

[GraphQL] Mutations have description field #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2020
Merged

[GraphQL] Mutations have description field #3477

merged 4 commits into from
Apr 22, 2020

Conversation

@MartkCz
Copy link
Contributor

@MartkCz MartkCz commented Apr 3, 2020

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT 
resources:
    App\Entity\Account:
        graphql:
            custom:
                mutation: App\Mutation\Account\CustomMutation
                description: Custom description

Before commit: Customs a Account
After commit: Custom description

alanpoulain
alanpoulain reviewed Apr 5, 2020
View reviewed changes
src/GraphQl/Type/FieldsBuilder.php
$shortName = $resourceMetadata->getShortName();
$resourceType = new Type(Type::BUILTIN_TYPE_OBJECT, true, $resourceClass);
$deprecationReason = $resourceMetadata->getGraphqlAttribute($mutationName, 'deprecation_reason', '', true);
$description = $resourceMetadata->getGraphqlAttribute($mutationName, 'description', ucfirst("{$mutationName}s a $shortName."), false);
Copy link
Member

@alanpoulain alanpoulain Apr 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add it before $deprecationReason?

alanpoulain
alanpoulain reviewed Apr 5, 2020
View reviewed changes
Copy link
Member

@alanpoulain alanpoulain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change it for the subscriptions too?

@alanpoulain
Copy link
Member

alanpoulain commented Apr 5, 2020

Maybe a test would be nice 🙂

@alanpoulain alanpoulain merged commit 8fde8f1 into api-platform:master Apr 22, 2020
@alanpoulain
Copy link
Member

alanpoulain commented Apr 22, 2020

Thank you @MartkCz.

@alanpoulain alanpoulain mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas dunglas approved these changes

@alanpoulain alanpoulain alanpoulain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MartkCz @alanpoulain @dunglas