Fix symfony/error-handler compatibility #3259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
commented
Nov 14, 2019
| "symfony/console": "^3.4 || ^4.0 || ^5.0", | ||
| "symfony/css-selector": "^3.4 || ^4.0 || ^5.0", | ||
| "symfony/debug": "^3.4 || ^4.0 || ^5.0", | ||
| "symfony/debug": "^3.4 || ^4.0", |
Contributor
Author
There was a problem hiding this comment.
debug:^5.0 does not exist.
dunglas
approved these changes
Nov 14, 2019
chalasr
force-pushed
the
error-handler
branch
from
f6811b9 to
f8d5c3c
Compare
Contributor
|
Still broken. |
chalasr
force-pushed
the
error-handler
branch
6 times, most recently
from
59ce9de to
4559aed
Compare
chalasr
force-pushed
the
error-handler
branch
from
4559aed to
d5a222f
Compare
Contributor
Author
|
@teohhanhui now green |
soyuka
approved these changes
Nov 15, 2019
Member
|
thanks @chalasr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symfony/error-render component has been reverted, its api has been partially added to the error-handler one.
This fixes the outdated compatibility layers and add some missing ones.