fix compat with Symfony 5 #3246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicolas-grekas
commented
Nov 12, 2019
nicolas-grekas
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
dunglas
reviewed
Nov 12, 2019
Contributor
|
This should target |
Contributor
Author
|
Now targetting branch 2.5 |
flug
approved these changes
Nov 14, 2019
chalasr
approved these changes
Nov 14, 2019
Member
|
Errors seem related. |
Contributor
|
Test mocking needs to handle both cases. |
Member
|
rebased + fixed by @flug waiting for CI |
teohhanhui
reviewed
Nov 15, 2019
teohhanhui
reviewed
Nov 15, 2019
teohhanhui
reviewed
Nov 15, 2019
Contributor
|
@soyuka You've messed up the indentation in I guess you need to install the EditorConfig plugin? 🙈 |
teohhanhui
reviewed
Nov 15, 2019
teohhanhui
approved these changes
Nov 15, 2019
Contributor
|
Looks like we still need to add more conditional mocking. |
soyuka
reviewed
Nov 15, 2019
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Nov 16, 2019
…t typed (chalasr) This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Flatten "exception" controller argument if not typed | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Fixes a BC break and makes it easier for libs to support both debug & error-handler e.g. api-platform/core#3246 (comment) Commits ------- 585216a [HttpKernel] Flatten "exception" controller argument if not typed
Member
|
Thanks @nicolas-grekas @chalasr @teohhanhui @flug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.