Make sure to always use the persistResult for follow-up actions #2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
May you add a regression test with your example? |
teohhanhui
approved these changes
Apr 5, 2019
Contributor
Author
I feel this already is, sort of, covered by the test I updated, but I will try to add a new test. |
soyuka
approved these changes
Apr 8, 2019
Contributor
Author
|
Ok, I've updated the test to have an assertion to test for any regression issues of the previous behaviour. |
teohhanhui
suggested changes
Apr 8, 2019
Not using the persistResult could cause issues in generating the IRI for new resources because the ID was not set on the controllerResult but only on the persistResult for example.
teohhanhui
approved these changes
Apr 9, 2019
Contributor
|
Thanks @Tjeerd! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not using the persistResult could cause issues in generating the IRI for
new resources because the ID was not set on the controllerResult but
only on the persistResult for example.