Skip to content

Conversation

@dongjoon-hyun
Copy link
Member Author

Hi, @cnauroth . Could you review this PR when you have some time?

@dongjoon-hyun
Copy link
Member Author

Thank you, @ctubbsii !

Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I'll plan on committing this tomorrow. Thank you, @dongjoon-hyun !

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @cnauroth !

@cnauroth cnauroth closed this in 89c1831 Apr 17, 2023
cnauroth added a commit that referenced this pull request Apr 17, 2023
Closes #1995

Signed-off-by: Chris Nauroth <[email protected]>
Reviewed-by: Christopher Tubbs <[email protected]>
(cherry picked from commit 89c1831)
cnauroth added a commit that referenced this pull request Apr 17, 2023
Closes #1995

Signed-off-by: Chris Nauroth <[email protected]>
Reviewed-by: Christopher Tubbs <[email protected]>
(cherry picked from commit 89c1831)
(cherry picked from commit 87935e9)
@cnauroth
Copy link
Contributor

I tested locally and confirmed successful generation of SBOM files. I have committed this to master, branch-3.8 and branch-3.7. @dongjoon-hyun , thank you!

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @cnauroth !

@cnauroth
Copy link
Contributor

@dongjoon-hyun , I botched this commit a bit and didn't preserve your authorship correctly. Really sorry about that! The credit remains with you on the JIRA issue though.

@dongjoon-hyun
Copy link
Member Author

No problem at all, @cnauroth . No worry! ;)

@dongjoon-hyun dongjoon-hyun deleted the ZOOKEEPER-4688 branch May 7, 2023 08:09
anurag-harness pushed a commit to anurag-harness/zookeeper that referenced this pull request Aug 31, 2023
anurag-harness added a commit to anurag-harness/zookeeper that referenced this pull request Aug 31, 2023
… (#48)

Closes apache#1995


Reviewed-by: Christopher Tubbs <[email protected]>

Signed-off-by: Chris Nauroth <[email protected]>
Co-authored-by: Chris Nauroth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants