Skip to content

[SECURITY] Fix Temporary Directory Hijacking or Information Disclosure Vulnerability #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[SECURITY] Fix Temporary Directory Hijacking or Information Disclosure Vulnerability #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import java.io.FileWriter;
import java.io.IOException;
import java.io.StringWriter;
import java.nio.file.Files;
import java.util.List;
import java.util.Set;

Expand Down Expand Up @@ -153,17 +154,7 @@ public void run()
private static File createTempDirectory( File baseTmpDirectory )
throws IOException
{
final File temp = File.createTempFile( "temp", Long.toString( System.nanoTime() ), baseTmpDirectory );

if ( !( temp.delete() ) )
{
throw new IOException( "Could not delete temp file: " + temp.getAbsolutePath() );
}

if ( !( temp.mkdir() ) )
{
throw new IOException( "Could not create temp directory: " + temp.getAbsolutePath() );
}
final File temp = Files.createTempDirectory(baseTmpDirectory.toPath(), "temp" + Long.toString(System.nanoTime())).toFile();

return temp;
}
Expand Down
13 changes: 2 additions & 11 deletions tomcat8-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/run/RunMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
import java.net.URISyntaxException;
import java.net.URL;
import java.net.URLClassLoader;
import java.nio.file.Files;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Enumeration;
Expand Down Expand Up @@ -182,17 +183,7 @@ public void run()
private static File createTempDirectory( File baseTmpDirectory )
throws IOException
{
final File temp = File.createTempFile( "temp", Long.toString( System.nanoTime() ), baseTmpDirectory );

if ( !( temp.delete() ) )
{
throw new IOException( "Could not delete temp file: " + temp.getAbsolutePath() );
}

if ( !( temp.mkdir() ) )
{
throw new IOException( "Could not create temp directory: " + temp.getAbsolutePath() );
}
final File temp = Files.createTempDirectory(baseTmpDirectory.toPath(), "temp" + Long.toString(System.nanoTime())).toFile();

return temp;
}
Expand Down