Skip to content

[SPARK-11973][SQL] Improve optimizer code readability. #9995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-11973][SQL] Improve optimizer code readability. #9995

wants to merge 2 commits into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Nov 26, 2015

This is a followup for #9959.

I added more documentation and rewrote some monadic code into simpler ifs.

@rxin
Copy link
Contributor Author

rxin commented Nov 26, 2015

cc @davies

cloud-fan
cloud-fan reviewed Nov 26, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala Outdated
Copy link
Contributor

@cloud-fan cloud-fan Nov 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filter(stayUp) -> Aggregate -> Filter(pushDownPredicate)? the -> looks like "having a child" to me.

Copy link
Contributor Author

@rxin rxin Nov 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm i'm going with how the data flows here.

Copy link
Contributor Author

@rxin rxin Nov 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i changed the direction of the arrows and also moved the operators around.

@SparkQA
Copy link

SparkQA commented Nov 26, 2015

Test build #46761 has finished for PR 9995 at commit fe3a9a4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 26, 2015

Test build #46775 has finished for PR 9995 at commit 95b2e0d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor

davies commented Nov 27, 2015

LGTM

@asfgit asfgit closed this in de28e4d Nov 27, 2015
asfgit pushed a commit that referenced this pull request Nov 27, 2015
@rxin
[SPARK-11973][SQL] Improve optimizer code readability.
f18de5a 
This is a followup for #9959.

I added more documentation and rewrote some monadic code into simpler ifs.

Author: Reynold Xin <[email protected]>

Closes #9995 from rxin/SPARK-11973.

(cherry picked from commit de28e4d)
Signed-off-by: Reynold Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rxin @SparkQA @davies @cloud-fan