[SPARK-11999][Core]Fix the issue that ThreadUtils.newDaemonCachedThreadPool doesn't cache any task #9978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e any task In the previous codes, newDaemonCachedThreadPool uses SynchronousQueue, which is wrong. SynchronousQueue is an empty queue that cannot cache any task. This patch uses LinkedBlockingQueue to fix it along with other fixes to make sure newDaemonCachedThreadPool can use at most `maxThreadNumber` threads, and after that, cache tasks to LinkedBlockingQueue.
Member
|
Seems fine to me. |
|
Test build #46714 has finished for PR 9978 at commit
|
Member
Author
|
retest this please |
|
Test build #46735 has finished for PR 9978 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Nov 26, 2015
…eadPool doesn't cache any task In the previous codes, `newDaemonCachedThreadPool` uses `SynchronousQueue`, which is wrong. `SynchronousQueue` is an empty queue that cannot cache any task. This patch uses `LinkedBlockingQueue` to fix it along with other fixes to make sure `newDaemonCachedThreadPool` can use at most `maxThreadNumber` threads, and after that, cache tasks to `LinkedBlockingQueue`. Author: Shixiong Zhu <[email protected]> Closes #9978 from zsxwing/cached-threadpool. (cherry picked from commit d3ef693) Signed-off-by: Shixiong Zhu <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Nov 26, 2015
…eadPool doesn't cache any task In the previous codes, `newDaemonCachedThreadPool` uses `SynchronousQueue`, which is wrong. `SynchronousQueue` is an empty queue that cannot cache any task. This patch uses `LinkedBlockingQueue` to fix it along with other fixes to make sure `newDaemonCachedThreadPool` can use at most `maxThreadNumber` threads, and after that, cache tasks to `LinkedBlockingQueue`. Author: Shixiong Zhu <[email protected]> Closes #9978 from zsxwing/cached-threadpool. (cherry picked from commit d3ef693) Signed-off-by: Shixiong Zhu <[email protected]>
Member
Author
|
merged to master/1.6/1.5/1.4 |
asfgit
pushed a commit
that referenced
this pull request
Nov 26, 2015
…eadPool doesn't cache any task In the previous codes, `newDaemonCachedThreadPool` uses `SynchronousQueue`, which is wrong. `SynchronousQueue` is an empty queue that cannot cache any task. This patch uses `LinkedBlockingQueue` to fix it along with other fixes to make sure `newDaemonCachedThreadPool` can use at most `maxThreadNumber` threads, and after that, cache tasks to `LinkedBlockingQueue`. Author: Shixiong Zhu <[email protected]> Closes #9978 from zsxwing/cached-threadpool. (cherry picked from commit d3ef693) Signed-off-by: Shixiong Zhu <[email protected]>
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Dec 3, 2015
…r and AppClient `SynchronousQueue` cannot cache any task. This issue is similar to apache#9978. It's an easy fix. Just use the fixed `ThreadUtils.newDaemonCachedThreadPool`. Author: Shixiong Zhu <[email protected]> Closes apache#10108 from zsxwing/fix-threadpool.
asfgit
pushed a commit
that referenced
this pull request
Dec 3, 2015
…r and AppClient `SynchronousQueue` cannot cache any task. This issue is similar to #9978. It's an easy fix. Just use the fixed `ThreadUtils.newDaemonCachedThreadPool`. Author: Shixiong Zhu <[email protected]> Closes #10108 from zsxwing/fix-threadpool. (cherry picked from commit 649be4f) Signed-off-by: Shixiong Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous codes,
newDaemonCachedThreadPoolusesSynchronousQueue, which is wrong.SynchronousQueueis an empty queue that cannot cache any task. This patch usesLinkedBlockingQueueto fix it along with other fixes to make surenewDaemonCachedThreadPoolcan use at mostmaxThreadNumberthreads, and after that, cache tasks toLinkedBlockingQueue.