-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-11963][DOC] Add docs for QuantileDiscretizer #9962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #46673 has finished for PR 9962 at commit
|
|
I'll review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the last instance, this uses 2.2, but your Markdown example uses 22. This must be the cause of the buckets being out-of-order in the example.
|
That's the only issue I see. |
|
Thanks @jkbradley, it's my fault. I tested both JavaQuantileDiscretizer and QuantileDiscretizer just now. Given the 4th row 2.2, we get the result showed in the doc, other than 22.0. So I changed the 22.0 -> 2.2 in both ml-features and JavaQuantileDiscretizerExample. |
|
Test build #47106 has finished for PR 9962 at commit
|
docs/ml-features.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"may be different" or "may differ" but not "may different"
|
There is a typo but otherwise it looks good. |
|
Thanks @BenFradet for the comments. I fixed them. |
|
Test build #47180 has finished for PR 9962 at commit
|
|
Thanks! I'll test once more and then merge |
|
Test build #2176 has finished for PR 9962 at commit
|
|
LGTM, merging with master and branch-1.6 |
https://issues.apache.org/jira/browse/SPARK-11963 Author: Xusen Yin <[email protected]> Closes #9962 from yinxusen/SPARK-11963. (cherry picked from commit 871e85d) Signed-off-by: Joseph K. Bradley <[email protected]>
https://issues.apache.org/jira/browse/SPARK-11963