Skip to content

Conversation

@yinxusen
Copy link
Contributor

@SparkQA
Copy link

SparkQA commented Nov 25, 2015

Test build #46673 has finished for PR 9962 at commit b054a54.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaQuantileDiscretizerExample\n

@jkbradley
Copy link
Member

I'll review now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last instance, this uses 2.2, but your Markdown example uses 22. This must be the cause of the buckets being out-of-order in the example.

@jkbradley
Copy link
Member

That's the only issue I see.

@yinxusen
Copy link
Contributor Author

yinxusen commented Dec 3, 2015

Thanks @jkbradley, it's my fault. I tested both JavaQuantileDiscretizer and QuantileDiscretizer just now. Given the 4th row 2.2, we get the result showed in the doc, other than 22.0. So I changed the 22.0 -> 2.2 in both ml-features and JavaQuantileDiscretizerExample.

@SparkQA
Copy link

SparkQA commented Dec 3, 2015

Test build #47106 has finished for PR 9962 at commit fede71b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaQuantileDiscretizerExample\n

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"may be different" or "may differ" but not "may different"

@BenFradet
Copy link
Contributor

There is a typo but otherwise it looks good.

@yinxusen
Copy link
Contributor Author

yinxusen commented Dec 4, 2015

Thanks @BenFradet for the comments. I fixed them.

@SparkQA
Copy link

SparkQA commented Dec 4, 2015

Test build #47180 has finished for PR 9962 at commit 17655aa.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaQuantileDiscretizerExample\n

@jkbradley
Copy link
Member

Thanks! I'll test once more and then merge

@SparkQA
Copy link

SparkQA commented Dec 7, 2015

Test build #2176 has finished for PR 9962 at commit 17655aa.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaQuantileDiscretizerExample\n

@jkbradley
Copy link
Member

LGTM, merging with master and branch-1.6

asfgit pushed a commit that referenced this pull request Dec 7, 2015
https://issues.apache.org/jira/browse/SPARK-11963

Author: Xusen Yin <[email protected]>

Closes #9962 from yinxusen/SPARK-11963.

(cherry picked from commit 871e85d)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in 871e85d Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants