[SPARK-11904] [PySpark] reduceByKeyAndWindow does not require checkpointing when invFunc is None #9888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduceByKeyAndWindow(func, None, window_size, slide_size) is equivalent to reduceByKey(func).window(window_size, slide_size).reduceByKey(func) and should not require checkpointing.
Contributor
Author
|
Any update on this please? |
Member
|
Jenkins, test this please |
Member
|
retest this please |
Member
|
LGTM pending tests |
Member
|
retest this please |
|
Test build #47848 has finished for PR 9888 at commit
|
Member
|
retest this please |
|
Test build #47856 has finished for PR 9888 at commit
|
Member
|
retest this please |
|
Test build #47870 has finished for PR 9888 at commit
|
Member
|
retest this please |
|
Test build #47877 has finished for PR 9888 at commit
|
Member
|
Merging to master. Thanks @dtolpin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when invFunc is None,
reduceByKeyAndWindow(func, None, winsize, slidesize)is equivalent toand no checkpoint is necessary. The corresponding Scala code does exactly that, but Python code always creates a windowed stream with obligatory checkpointing. The patch fixes this.
I do not know how to unit-test this.