Skip to content

[SPARK-11899][SQL] API audit for GroupedDataset. #9880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-11899][SQL] API audit for GroupedDataset. #9880

wants to merge 1 commit into from

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Nov 21, 2015

  1. Renamed map to mapGroup, flatMap to flatMapGroup.
  2. Renamed asKey -> keyAs.
  3. Added more documentation.
  4. Changed type parameter T to V on GroupedDataset.
  5. Added since versions for all functions.

@rxin
[SPARK-11899][SQL] API audit for GroupedDataset.
aacd652 
1. Renamed map to mapGroup, flatMap to flatMapGroup.
2. Added more documentation.
3. Changed type parameter T to V on GroupedDataset.
4. Added since versions for all functions.
@SparkQA
Copy link

SparkQA commented Nov 21, 2015

Test build #46471 has finished for PR 9880 at commit aacd652.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Nov 21, 2015

Jenkins, retest this please.

1 similar comment
@JoshRosen
Copy link
Contributor

JoshRosen commented Nov 21, 2015

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Nov 21, 2015

Test build #46477 has finished for PR 9880 at commit aacd652.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

JoshRosen
JoshRosen reviewed Nov 21, 2015
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/GroupedDataset.scala
Copy link
Contributor

@JoshRosen JoshRosen Nov 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this variable be renamed to vEncoder?

Copy link
Contributor Author

@rxin rxin Nov 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea that's a good catch. will fix it in my next pr.

@JoshRosen
Copy link
Contributor

JoshRosen commented Nov 21, 2015

LGTM aside from one minor variable naming nit.

@asfgit asfgit closed this in ff442bb Nov 21, 2015
asfgit pushed a commit that referenced this pull request Nov 21, 2015
@rxin
[SPARK-11899][SQL] API audit for GroupedDataset.
8c718a5 
1. Renamed map to mapGroup, flatMap to flatMapGroup.
2. Renamed asKey -> keyAs.
3. Added more documentation.
4. Changed type parameter T to V on GroupedDataset.
5. Added since versions for all functions.

Author: Reynold Xin <[email protected]>

Closes #9880 from rxin/SPARK-11899.

(cherry picked from commit ff442bb)
Signed-off-by: Reynold Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rxin @SparkQA @JoshRosen