[SPARK-11809] Switch the default Mesos mode to coarse-grained mode #9795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
LGTM. |
docs/running-on-mesos.md
Outdated
Contributor
There was a problem hiding this comment.
now that this is the default I think we can just leave this one out. Instead we should be telling people how to use fine-grained mode by setting this to false (as we already do so below)
Contributor
There was a problem hiding this comment.
that or say set the property to true (already the default) or something
Contributor
|
LGTM |
|
Test build #46183 has finished for PR 9795 at commit
|
Contributor
|
LGTM as well! |
Contributor
|
retest this please |
Contributor
Author
|
Alright I updated the doc based on andrew's comment. Going to merge it. |
asfgit
pushed a commit
that referenced
this pull request
Nov 18, 2015
Based on my conversions with people, I believe the consensus is that the coarse-grained mode is more stable and easier to reason about. It is best to use that as the default rather than the more flaky fine-grained mode. Author: Reynold Xin <[email protected]> Closes #9795 from rxin/SPARK-11809. (cherry picked from commit a416e41) Signed-off-by: Reynold Xin <[email protected]>
|
Test build #46230 has finished for PR 9795 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my conversions with people, I believe the consensus is that the coarse-grained mode is more stable and easier to reason about. It is best to use that as the default rather than the more flaky fine-grained mode.