Skip to content

[SPARK-11812] [PySpark] invFunc=None works properly with python's reduceByKeyAndWindow #9775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-11812] [PySpark] invFunc=None works properly with python's reduceByKeyAndWindow #9775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f777e1
invFunc=none work properly with python's reduceByKeyAndWindow
dtolpin Nov 17, 2015
e76be01
added unit test for reduceByKeyAndWindow with invFunc=None
dtolpin Nov 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/pyspark/streaming/dstream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,8 @@ def reduceByKeyAndWindow(self, func, invFunc, windowDuration, slideDuration=None
`invFunc` can be None, then it will reduce all the RDDs in window, could be slower
than having `invFunc`.

@param reduceFunc: associative reduce function
@param invReduceFunc: inverse function of `reduceFunc`
@param func: associative reduce function
@param invFunc: inverse function of `reduceFunc`
@param windowDuration: width of the window; must be a multiple of this DStream's
batching interval
@param slideDuration: sliding interval of the window (i.e., the interval after which
Expand Down Expand Up @@ -556,7 +556,7 @@ def invReduceFunc(t, a, b):
if kv[1] is not None else kv[0])

jreduceFunc = TransformFunction(self._sc, reduceFunc, reduced._jrdd_deserializer)
if invReduceFunc:
if invFunc:
jinvReduceFunc = TransformFunction(self._sc, invReduceFunc, reduced._jrdd_deserializer)
else:
jinvReduceFunc = None
Expand Down
11 changes: 11 additions & 0 deletions python/pyspark/streaming/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,17 @@ def test_reduce_by_invalid_window(self):
self.assertRaises(ValueError, lambda: d1.reduceByKeyAndWindow(None, None, 0.1, 0.1))
self.assertRaises(ValueError, lambda: d1.reduceByKeyAndWindow(None, None, 1, 0.1))

def test_reduce_by_key_and_window_with_none_invFunc(self):
input = [range(1), range(2), range(3), range(4), range(5), range(6)]

def func(dstream):
return dstream.map(lambda x: (x, 1))\
.reduceByKeyAndWindow(operator.add, None, 5, 1)\
.filter(lambda kv: kv[1] > 0).count()

expected = [[2], [4], [6], [6], [6], [6]]
self._test_func(input, func, expected)


class StreamingContextTests(PySparkStreamingTestCase):

Expand Down