Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Nov 16, 2015

Fixed the merge conflicts in #7410

Closes #7410

@SparkQA
Copy link

SparkQA commented Nov 16, 2015

Test build #46004 has finished for PR 9742 at commit 59df9ee.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class PythonMessageAndMetadata(\n * class PythonMessageAndMetadataPickler extends IObjectPickler\n * class KafkaMessageAndMetadata(object):\n

@zsxwing
Copy link
Member Author

zsxwing commented Nov 17, 2015

@jerryshao After discussing with @tdas offline, I added some codes to speed up the case when the user doesn't provide a messageHandler. So that we can avoid message serialization for this case and won't reduce the performance. Could you take a look?

@jerryshao
Copy link
Contributor

OK, let me check. But I'm wondering if there's a huge overhead for message serialization, since we only pack some of metadatas into message, don't do serialization-deserialization on the real message itself, not sure what's actual performance loss will happen.

@jerryshao
Copy link
Contributor

LGTM.

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #46033 has finished for PR 9742 at commit 48aa7c3.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class PythonMessageAndMetadata(\n * class PythonMessageAndMetadataPickler extends IObjectPickler\n * class KafkaMessageAndMetadata(object):\n

@zsxwing
Copy link
Member Author

zsxwing commented Nov 17, 2015

retest this please

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: incorrect indent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this default_message_handler

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #46045 has finished for PR 9742 at commit f7ad2e3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #2068 has finished for PR 9742 at commit f7ad2e3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class PythonMessageAndMetadata(\n * class PythonMessageAndMetadataPickler extends IObjectPickler\n * class KafkaMessageAndMetadata(object):\n

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #46040 has finished for PR 9742 at commit d3f135d.

  • This patch fails from timeout after a configured wait of 250m.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class PythonMessageAndMetadata(\n * class PythonMessageAndMetadataPickler extends IObjectPickler\n * class KafkaMessageAndMetadata(object):\n

@zsxwing
Copy link
Member Author

zsxwing commented Nov 17, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #46060 has finished for PR 9742 at commit f7ad2e3.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class PythonMessageAndMetadata(\n * class PythonMessageAndMetadataPickler extends IObjectPickler\n * class KafkaMessageAndMetadata(object):\n

@zsxwing
Copy link
Member Author

zsxwing commented Nov 17, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #46097 has finished for PR 9742 at commit f7ad2e3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class PythonMessageAndMetadata(\n * class PythonMessageAndMetadataPickler extends IObjectPickler\n * class KafkaMessageAndMetadata(object):\n * case class JSONOptions(\n

@SparkQA
Copy link

SparkQA commented Nov 18, 2015

Test build #46115 has finished for PR 9742 at commit b2bbfee.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaLinearRegressionWithElasticNetExample\n * public class JavaLogisticRegressionSummaryExample\n * public class JavaLogisticRegressionWithElasticNetExample\n * case class PythonMessageAndMetadata(\n * class PythonMessageAndMetadataPickler extends IObjectPickler\n * class HashingTF(override val uid: String)\n * class Interaction @Since(\"1.6.0\") (override val uid: String) extends Transformer\n * class Normalizer(override val uid: String)\n * class SQLTransformer @Since(\"1.6.0\") (override val uid: String) extends Transformer with Writable\n * class Tokenizer(override val uid: String)\n * class KafkaMessageAndMetadata(object):\n * case class ArrayConversion(elementConversion: JDBCConversion) extends JDBCConversion\n * abstract class JdbcDialect extends Serializable\n

@tdas
Copy link
Contributor

tdas commented Nov 18, 2015

All right. I am merging to master and 1.6. Thanks @jerryshao for all the effort, and @zsxwing for getting this ready.

asfgit pushed a commit that referenced this pull request Nov 18, 2015
Fixed the merge conflicts in #7410

Closes #7410

Author: Shixiong Zhu <[email protected]>
Author: jerryshao <[email protected]>
Author: jerryshao <[email protected]>

Closes #9742 from zsxwing/pr7410.

(cherry picked from commit 75a2922)
Signed-off-by: Tathagata Das <[email protected]>
@asfgit asfgit closed this in 75a2922 Nov 18, 2015
@jerryshao
Copy link
Contributor

Thanks a lot @tdas and @zsxwing to make it merged, appreciated.

@zsxwing zsxwing deleted the pr7410 branch November 18, 2015 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants