Skip to content

Conversation

@somideshmukh
Copy link
Contributor

Made changes in code according to spark coding style.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to change TfIdfExample to HashingTF. You can treat examples in the section Feature Extractors as examples, since TF-IDF, Word2Vec, and CountVectorizer have already been written with include_example.

@yinxusen
Copy link
Contributor

Hi @somideshmukh, thanks for working on this. You can use the PR #9713 as an example. What we need to do is replacing all raw code snippts in ml-features.md with include_example, and create code files in the examples dir of Spark accordingly.

@yinxusen
Copy link
Contributor

@somideshmukh Do you still have time on this? I can help if you are busy. Pls let me know. :)

@somideshmukh
Copy link
Contributor Author

Hi,The Patch that I have submitted contains code of Java and Scala ,that I have replaced.About Python code I donot have much experience.So haven't touch that part.Iif there are any other Java or Scala classes that need to replaced please let me know

@mengxr
Copy link
Contributor

mengxr commented Nov 24, 2015

@somideshmukh It seems that there is some miscommunication about the task. It is to move example code embedded in markdown to examples/ folder, and then use include_example in markdown to reference them. But this PR adds some example code back from examples/ to markdown, which is what we want to avoid. Could you update your PR? It might be good to change only one example first and confirm with @yinxusen about the correctness, and then work on others.

@yinxusen
Copy link
Contributor

@somideshmukh Could we close this PR since there is a new one #10002 of SPARK-11551

@somideshmukh
Copy link
Contributor Author

Yes ,you can close this PR

@yinxusen
Copy link
Contributor

@somideshmukh I can't close it because I am not the owner. You need close it yourself. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants