Skip to content

Conversation

@nevillelyh
Copy link
Contributor

This is very useful when debugging & fine tuning jobs with large data sets.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@mengxr
Copy link
Contributor

mengxr commented Jun 4, 2014

Jenkins, test this please.

@AmplabJenkins
Copy link

Merged build triggered.

@mengxr
Copy link
Contributor

mengxr commented Jun 4, 2014

LGTM. Waiting for Jenkins.

@AmplabJenkins
Copy link

Merged build started.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is more concise to use

s"users-$iter"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, fixed.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15439/

@mengxr
Copy link
Contributor

mengxr commented Jun 4, 2014

Merged. Thanks!

@asfgit asfgit closed this in b8d2580 Jun 4, 2014
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
This is very useful when debugging & fine tuning jobs with large data sets.

Author: Neville Li <[email protected]>

Closes apache#966 from nevillelyh/master and squashes the following commits:

6747764 [Neville Li] [MLLIB] use string interpolation for RDD names
3b15d34 [Neville Li] [MLLIB] set RDD names in ALS
nevillelyh added a commit to nevillelyh/spark that referenced this pull request Jul 7, 2014
This is very useful when debugging & fine tuning jobs with large data sets.

Author: Neville Li <[email protected]>

Closes apache#966 from nevillelyh/master and squashes the following commits:

6747764 [Neville Li] [MLLIB] use string interpolation for RDD names
3b15d34 [Neville Li] [MLLIB] set RDD names in ALS
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
This is very useful when debugging & fine tuning jobs with large data sets.

Author: Neville Li <[email protected]>

Closes apache#966 from nevillelyh/master and squashes the following commits:

6747764 [Neville Li] [MLLIB] use string interpolation for RDD names
3b15d34 [Neville Li] [MLLIB] set RDD names in ALS
wangyum added a commit that referenced this pull request May 26, 2023
… CombineUnions if it hasCorrelatedSubquery (#966)

* [SPARK-39216][SQL] Do not collapse projects in CombineUnions if it hasCorrelatedSubquery

### What changes were proposed in this pull request?

Makes `CombineUnions` do not collapse projects if it hasCorrelatedSubquery. For example:
```sql
SELECT (SELECT IF(x, 1, 0)) AS a
FROM (SELECT true) t(x)
UNION
SELECT 1 AS a
```

It will throw exception:
```
java.lang.IllegalStateException: Couldn't find x#4 in []
```

### Why are the changes needed?

Fix bug.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unit test.

Closes #36595 from wangyum/SPARK-39216.

Authored-by: Yuming Wang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>

(cherry picked from commit 85bb7bf)

* Update SQLQuerySuite.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants