[SPARK-11031][SPARKR] Method str() on a DataFrame #9613

olarayej · 2015-11-11T01:21:16Z

No description provided.

olarayej · 2015-11-11T01:23:37Z

The output of this method looks like this:

irisDF <- createDataFrame(sqlContext, iris)

str(irisDF)
'DataFrame': 150 obs. of 5 variables:
$ Sepal_Length: num 5.1 4.9 4.7 4.6 5 5.4 ...
$ Sepal_Width : num 3.5 3 3.2 3.1 3.6 3.9 ...
$ Petal_Length: num 1.4 1.4 1.3 1.5 1.4 1.7 ...
$ Petal_Width : num 0.2 0.2 0.2 0.2 0.2 0.4 ...
$ Species : chr setosa setosa setosa setosa setosa setosa ...

SparkQA · 2015-11-11T01:34:32Z

Test build #45577 has finished for PR 9613 at commit dab0565.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2015-11-11T02:07:52Z

Test build #45579 has finished for PR 9613 at commit d825d2c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

olarayej · 2015-11-11T22:02:19Z

@shivaram @felixcheung Can anybody review this one? I'd appreciate it. Thanks!

felixcheung · 2015-11-13T00:01:11Z

R/pkg/R/DataFrame.R

use paste0?

SparkQA · 2015-11-14T02:11:26Z

Test build #45916 has finished for PR 9613 at commit daa3d41.

This patch fails R style tests.
This patch does not merge cleanly.
This patch adds no public classes.

SparkQA · 2015-11-14T02:24:39Z

Test build #45917 has finished for PR 9613 at commit 5b4f6b1.

This patch fails R style tests.
This patch does not merge cleanly.
This patch adds no public classes.

olarayej · 2015-11-14T02:29:57Z

I'm getting the error below, but such line is blank. Jenkins, could you retest please?

inst/tests/test_sparkSQL.R:1542:1: Warning messages:
1: In readLines(filename) :style: Trailing whitespace is superfluous.

shivaram · 2015-11-14T02:44:37Z

@olarayej The empty line could still have whitespaces that'll need to be removed to pass the style checker

olarayej · 2015-11-14T02:48:32Z

@shivaram Yeah, by empty line I meant completely empty (no spaces or anything). Now it's passing. I believe it was picking up and old version of my file :-). Thanks!

SparkQA · 2015-11-14T05:40:02Z

Test build #45918 has finished for PR 9613 at commit 6d226e9.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

felixcheung · 2015-11-15T03:25:59Z

R/pkg/R/DataFrame.R

I understand that, the check on SHORT_TYPES is below in line 2278 though?
here, types is still "character" right?

felixcheung · 2015-12-18T04:18:20Z

also this comment #9613 (diff)

SparkQA · 2015-12-18T19:29:13Z

Test build #48016 has finished for PR 9613 at commit 1428925.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2015-12-18T20:30:48Z

Test build #48021 has finished for PR 9613 at commit 5bdf3f9.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2015-12-18T22:40:29Z

Test build #48028 has finished for PR 9613 at commit 38c21f3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

olarayej · 2015-12-19T00:03:44Z

@felixcheung Done!

olarayej · 2015-12-22T07:50:29Z

@shivaram I have addressed all your comments. Should we close this pull request?

olarayej · 2016-01-11T17:22:46Z

Happy New Year, folks! Shall we merge this PR? @shivaram

shivaram · 2016-01-11T20:14:14Z

Sorry I've been traveling for the last couple of weeks. I get back on
Tuesday and will take a look
On Jan 11, 2016 09:23, "Oscar D. Lara Yejas" [email protected]
wrote:

Happy New Year, folks! Shall we merge this PR? @shivaram
https://github.com/shivaram

—
Reply to this email directly or view it on GitHub
#9613 (comment).

felixcheung · 2016-01-12T03:35:09Z

R/pkg/R/generics.R

it looks like with is duplicated:
https://github.com/olarayej/spark/blob/SPARK-11031/R/pkg/R/generics.R

Fixed this and also re-ordered generics declaration for attach and as.data.frame.

…Frame

SparkQA · 2016-01-12T18:49:58Z

Test build #49249 has finished for PR 9613 at commit 2a8115d.

This patch fails some tests.
This patch merges cleanly.
This patch adds no public classes.

olarayej · 2016-01-12T18:53:49Z

Jenkins, could you retest please? The error I see is "Error fetching remote repo 'origin'"

olarayej · 2016-01-12T23:44:35Z

@SparkQA Could you retest?

shivaram · 2016-01-13T00:11:21Z

Jenkins, retest this please

SparkQA · 2016-01-13T00:24:34Z

Test build #49272 has finished for PR 9613 at commit 2a8115d.

This patch fails some tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-01-13T20:00:41Z

Test build #49327 has finished for PR 9613 at commit 0ffcb4f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

olarayej · 2016-01-13T21:33:59Z

@felixcheung Done. Thanks!

felixcheung · 2016-01-13T23:42:48Z

looks good and test passed!

shivaram · 2016-01-15T15:37:04Z

LGTM from me as well. Thanks @olarayej - Merging this to master and branch-1.6.

Author: Oscar D. Lara Yejas <[email protected]> Author: Oscar D. Lara Yejas <[email protected]> Author: Oscar D. Lara Yejas <[email protected]> Author: Oscar D. Lara Yejas <[email protected]> Closes #9613 from olarayej/SPARK-11031. (cherry picked from commit ba4a641) Signed-off-by: Shivaram Venkataraman <[email protected]>

olarayej · 2016-01-15T19:02:16Z

Thanks, @shivaram!

Method str()

dab0565

Oscar D. Lara Yejas added 2 commits November 11, 2015 01:40

Fixed R style issues

b5129cd

Fixed R style issues

d825d2c

felixcheung reviewed Nov 13, 2015
View reviewed changes

R/pkg/R/DataFrame.R Outdated

Copy link

Member

felixcheung Nov 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use paste0?

Fixed style. Added more specific tests

daa3d41

Oscar D. Lara Yejas added 2 commits November 14, 2015 02:16

Replaced %++% by paste0

5b4f6b1

Removed white space

6d226e9

felixcheung reviewed Nov 15, 2015
View reviewed changes

Added back transform()

1428925

Oscar D. Lara Yejas added 2 commits December 18, 2015 12:11

Removed space

40a5202

Removed space

5bdf3f9

Removed space

38c21f3

felixcheung reviewed Jan 12, 2016
View reviewed changes

Oscar D. Lara Yejas added 2 commits January 12, 2016 10:30

Removed duplicate with() declaration and re-ordered generics for Data…

2701898

…Frame

Made spacing uniform for types.R

2a8115d

Changed rdname of transform for mutate

0ffcb4f

asfgit closed this in ba4a641 Jan 15, 2016

[SPARK-11031][SPARKR] Method str() on a DataFrame #9613

[SPARK-11031][SPARKR] Method str() on a DataFrame #9613

Uh oh!

Conversation

olarayej commented Nov 11, 2015

Uh oh!

olarayej commented Nov 11, 2015

Uh oh!

SparkQA commented Nov 11, 2015

Uh oh!

SparkQA commented Nov 11, 2015

Uh oh!

olarayej commented Nov 11, 2015

Uh oh!

felixcheung Nov 13, 2015

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Nov 14, 2015

Uh oh!

SparkQA commented Nov 14, 2015

Uh oh!

olarayej commented Nov 14, 2015

Uh oh!

shivaram commented Nov 14, 2015

Uh oh!

olarayej commented Nov 14, 2015

Uh oh!

SparkQA commented Nov 14, 2015

Uh oh!

felixcheung Nov 15, 2015

Choose a reason for hiding this comment

Uh oh!

felixcheung commented Dec 18, 2015

Uh oh!

SparkQA commented Dec 18, 2015

Uh oh!

SparkQA commented Dec 18, 2015

Uh oh!

SparkQA commented Dec 18, 2015

Uh oh!

olarayej commented Dec 19, 2015

Uh oh!

olarayej commented Dec 22, 2015

Uh oh!

olarayej commented Jan 11, 2016

Uh oh!

shivaram commented Jan 11, 2016

Uh oh!

felixcheung Jan 12, 2016

Choose a reason for hiding this comment

Uh oh!

olarayej Jan 12, 2016

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Jan 12, 2016

Uh oh!

olarayej commented Jan 12, 2016

Uh oh!

olarayej commented Jan 12, 2016

Uh oh!

shivaram commented Jan 13, 2016

Uh oh!

SparkQA commented Jan 13, 2016

Uh oh!

SparkQA commented Jan 13, 2016

Uh oh!

olarayej commented Jan 13, 2016

Uh oh!

felixcheung commented Jan 13, 2016

Uh oh!

shivaram commented Jan 15, 2016

Uh oh!

olarayej commented Jan 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development