Skip to content

Conversation

@yhuai
Copy link
Contributor

@yhuai yhuai commented Nov 10, 2015

https://issues.apache.org/jira/browse/SPARK-9830

This is the follow-up pr for #9556 to address @davies' comments.

@davies
Copy link
Contributor

davies commented Nov 10, 2015

LGTM

@rxin
Copy link
Contributor

rxin commented Nov 10, 2015

Please also close this ticket when you merge the commit: https://issues.apache.org/jira/browse/SPARK-11641

@yhuai yhuai changed the title [SPARK-9830] [SQL] [FOLLOW-UP] Remove AggregateExpression1 and Aggregate Operator used to evaluate AggregateExpression1s [SPARK-9830] [SPARK-11641] [SQL] [FOLLOW-UP] Remove AggregateExpression1 and update toString of Exchange Nov 10, 2015
@SparkQA
Copy link

SparkQA commented Nov 11, 2015

Test build #45559 has finished for PR 9607 at commit ce3f4db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor Author

yhuai commented Nov 11, 2015

Thanks @davies for review. I am merging it to master and branch 1.6.

asfgit pushed a commit that referenced this pull request Nov 11, 2015
… and update toString of Exchange

https://issues.apache.org/jira/browse/SPARK-9830

This is the follow-up pr for #9556 to address davies' comments.

Author: Yin Huai <[email protected]>

Closes #9607 from yhuai/removeAgg1-followup.

(cherry picked from commit 3121e78)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 3121e78 Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants