-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-10863][SPARKR] Method coltypes() (New version) #9579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #45451 has finished for PR 9579 at commit
|
|
@olarayej could you please check the style warnings with |
R/pkg/R/schema.R
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid search, if (!is.null(PRIMITIVE_TYPES[[type]]))
|
Test build #45453 has finished for PR 9579 at commit
|
R/pkg/R/DataFrame.R
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add family
#' @family dataframe_funcs
and example, like
#' @examples
#' \dontrun{
#' with(irisDf, nrow(Sepal_Width))
#' }
|
Test build #45461 has finished for PR 9579 at commit
|
|
LGTM |
|
I have addressed the docs suggestions. Thank you folks. |
|
Test build #45499 has finished for PR 9579 at commit
|
|
@felixcheung @sun-rui All set. Can we please merge? Thanks! |
|
Thanks @olarayej @sun-rui and @felixcheung. LGTM and merging this |
This is a follow up on PR #8984, as the corresponding branch for such PR was damaged. Author: Oscar D. Lara Yejas <[email protected]> Closes #9579 from olarayej/SPARK-10863_NEW14. (cherry picked from commit 47735cd) Signed-off-by: Shivaram Venkataraman <[email protected]>
This is a follow up on PR #8984, as the corresponding branch for such PR was damaged.