Skip to content

Conversation

@olarayej
Copy link

This is a follow up on PR #8984, as the corresponding branch for such PR was damaged.

@SparkQA
Copy link

SparkQA commented Nov 10, 2015

Test build #45451 has finished for PR 9579 at commit 635bbe7.

  • This patch fails R style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yu-iskw
Copy link
Contributor

yu-iskw commented Nov 10, 2015

@olarayej could you please check the style warnings with ./dev/lint-r on your local computer before pushing commits. Thanks.

R/pkg/R/schema.R Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid search, if (!is.null(PRIMITIVE_TYPES[[type]]))

@SparkQA
Copy link

SparkQA commented Nov 10, 2015

Test build #45453 has finished for PR 9579 at commit 0eabaf8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add family

#' @family dataframe_funcs

and example, like

#' @examples
#' \dontrun{
#' with(irisDf, nrow(Sepal_Width))
#' }

@felixcheung
Copy link
Member

doc comment, looks good to me otherwise.
@sun-rui @shivaram

@SparkQA
Copy link

SparkQA commented Nov 10, 2015

Test build #45461 has finished for PR 9579 at commit a031aed.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class TypedColumn[-T, U](expr: Expression, val encoder: Encoder[U]) extends Column(expr)\n * case class TypedAggregateExpression(\n * abstract class Aggregator[-A, B, C]\n

@sun-rui
Copy link
Contributor

sun-rui commented Nov 10, 2015

LGTM

@olarayej
Copy link
Author

I have addressed the docs suggestions. Thank you folks.

@SparkQA
Copy link

SparkQA commented Nov 10, 2015

Test build #45499 has finished for PR 9579 at commit 01366a6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@olarayej
Copy link
Author

@felixcheung @sun-rui All set. Can we please merge? Thanks!

@shivaram
Copy link
Contributor

Thanks @olarayej @sun-rui and @felixcheung. LGTM and merging this

asfgit pushed a commit that referenced this pull request Nov 10, 2015
This is a follow up on PR #8984, as the corresponding branch for such PR was damaged.

Author: Oscar D. Lara Yejas <[email protected]>

Closes #9579 from olarayej/SPARK-10863_NEW14.

(cherry picked from commit 47735cd)
Signed-off-by: Shivaram Venkataraman <[email protected]>
@asfgit asfgit closed this in 47735cd Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants