Skip to content

Conversation

@felixcheung
Copy link
Member

Make sample test less flaky by setting the seed

Tested with

repeat {  if (count(sample(df, FALSE, 0.1)) == 3) { break } }

@felixcheung
Copy link
Member Author

@shivaram @adrian555

@felixcheung felixcheung changed the title Flaky SparkR test: test_sparkSQL.R: sample on a DataFrame [SPARK-9865][SPARKR] Flaky SparkR test: test_sparkSQL.R: sample on a DataFrame Nov 8, 2015
@SparkQA
Copy link

SparkQA commented Nov 8, 2015

Test build #45320 has finished for PR 9549 at commit 6869ba1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram
Copy link
Contributor

shivaram commented Nov 9, 2015

LGTM. Thanks @felixcheung -- Merging this

asfgit pushed a commit that referenced this pull request Nov 9, 2015
…DataFrame

Make sample test less flaky by setting the seed

Tested with
```
repeat {  if (count(sample(df, FALSE, 0.1)) == 3) { break } }
```

Author: felixcheung <[email protected]>

Closes #9549 from felixcheung/rsample.

(cherry picked from commit cd17488)
Signed-off-by: Shivaram Venkataraman <[email protected]>
@asfgit asfgit closed this in cd17488 Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants