Skip to content

[SPARK-11572] Exit AsynchronousListenerBus thread when stop() is called #9546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[SPARK-11572] Exit AsynchronousListenerBus thread when stop() is called #9546

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c60b860
Exit AsynchronousListenerBus thread when stop() is called
tedyu Nov 8, 2015
9a6f9ff
Address Andrew's review comments
tedyu Nov 10, 2015
9acce70
Move stopped.get() into try block
tedyu Nov 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions core/src/main/scala/org/apache/spark/util/AsynchronousListenerBus.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,12 @@ private[spark] abstract class AsynchronousListenerBus[L <: AnyRef, E](name: Stri
processingEvent = true
}
try {
val event = eventQueue.poll
if (event == null) {
if (stopped.get()) {
// Get out of the while loop and shutdown the daemon thread
if (!stopped.get) {
throw new IllegalStateException("Polling `null` from eventQueue means" +
" the listener bus has been stopped. So `stopped` must be true")
}
return
}
val event = eventQueue.poll
assert(event != null, "event queue was empty but the listener bus was not stopped")
postToAll(event)
} finally {
self.synchronized {
Expand Down