-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Typo fixes + code readability improvements #9501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a duplication since getInputFormat does exactly this.
|
Except one comment, all the changes look fine, but I'm not sure I think it's a great use of time. Most of these are very marginal clarifications or spacing fixes. I'd prefer to focus on more substantive changes, as mentioned several times before. How can we do that? |
|
Thanks @srowen for reviewing the changes. They indeed are small since they're the outcome of me going through the code and learning Spark this way. When I run across a typo or similar inconsistency, I fix it and move on. If you've got a task at hand I could work on - something small(ish) - I'd love to hear about it. Guide me. |
|
Typos, maybe, or doc fixes. Some of these aren't fixes, or are just whitespace changes. It's not worth the time, really, unless you're cleaning up along the way to another change or are zapping a bunch of instances in one go. Look at the |
|
Test build #1996 has finished for PR 9501 at commit
|
|
The only files that touch spaces are What should I do with the changes? On to the starter tag... |
|
Merged to master |
|
Thanks again @srowen! Next pull req should be from starter tag. |
Author: Jacek Laskowski <[email protected]> Closes #9501 from jaceklaskowski/typos-with-style. (cherry picked from commit 62bb290) Signed-off-by: Reynold Xin <[email protected]>
No description provided.