Skip to content

Conversation

@jaceklaskowski
Copy link
Contributor

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can this be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a duplication since getInputFormat does exactly this.

@srowen
Copy link
Member

srowen commented Nov 5, 2015

Except one comment, all the changes look fine, but I'm not sure I think it's a great use of time. Most of these are very marginal clarifications or spacing fixes. I'd prefer to focus on more substantive changes, as mentioned several times before. How can we do that?

@jaceklaskowski
Copy link
Contributor Author

Thanks @srowen for reviewing the changes. They indeed are small since they're the outcome of me going through the code and learning Spark this way. When I run across a typo or similar inconsistency, I fix it and move on.

If you've got a task at hand I could work on - something small(ish) - I'd love to hear about it. Guide me.

@srowen
Copy link
Member

srowen commented Nov 6, 2015

Typos, maybe, or doc fixes. Some of these aren't fixes, or are just whitespace changes. It's not worth the time, really, unless you're cleaning up along the way to another change or are zapping a bunch of instances in one go.

Look at the starter label. This is answered in https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark

@SparkQA
Copy link

SparkQA commented Nov 6, 2015

Test build #1996 has finished for PR 9501 at commit aa911d5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * final class DecisionTreeRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n * final class GBTRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n * class IsotonicRegression @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)\n * class LinearRegression @Since(\"1.3.0\") (@Since(\"1.3.0\") override val uid: String)\n * final class RandomForestRegressor @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)\n

@jaceklaskowski
Copy link
Contributor Author

The only files that touch spaces are ShuffleMapTask.scala and TaskSet.scala (and these could be reverted). The others look more than space fixes.

What should I do with the changes?

On to the starter tag...

@srowen
Copy link
Member

srowen commented Nov 6, 2015

Merged to master

@asfgit asfgit closed this in 62bb290 Nov 6, 2015
@jaceklaskowski
Copy link
Contributor Author

Thanks again @srowen! Next pull req should be from starter tag.

asfgit pushed a commit that referenced this pull request Nov 9, 2015
Author: Jacek Laskowski <[email protected]>

Closes #9501 from jaceklaskowski/typos-with-style.

(cherry picked from commit 62bb290)
Signed-off-by: Reynold Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants