-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-11468][SPARKR] add stddev/variance agg functions for Column #9489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #45109 has finished for PR 9489 at commit
|
|
Test build #45148 has finished for PR 9489 at commit
|
|
cc @sun-rui |
|
LGTM |
|
Should we add aliases |
|
Looks like dply has aggregate functions for variance, standard deviations ? Can we just match the syntax there ? https://www.rstudio.com/wp-content/uploads/2015/02/data-wrangling-cheatsheet.pdf |
|
This does work Also these work I think they match dplyr, so I could name them |
|
@shivaram, I looked at dplyr package, there is no "sd", "var" defined in the package, seems the page is referencing "sd" "var" in R base. Yes, stddev/variance agg functions we are adding have similar semantic as "sd" and "var" in R, as you can think of a Column as a vector of same type. So we'd better add aliases for them. Note that var() in R computes sample variance (I think "sd" also uses sample variance, but not verified) instead of population variance. |
R/pkg/NAMESPACE
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"stddev_pop" before "stddev_samp",
|
Yeah in that case lets add aliases for @felixcheung I think similar functions like |
|
Test build #45581 has finished for PR 9489 at commit
|
|
Test build #45585 has finished for PR 9489 at commit
|
|
LGTM |
|
Merging this into master and 1.6 branch, thanks! |
Checked names, none of them should conflict with anything in base shivaram davies rxin Author: felixcheung <[email protected]> Closes #9489 from felixcheung/rstddev. (cherry picked from commit 1a8e046) Signed-off-by: Davies Liu <[email protected]>
Checked names, none of them should conflict with anything in base
@shivaram @davies @rxin