Skip to content

Conversation

@yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Oct 28, 2015

cc @mengxr @noel-smith

I worked on this issues based on #8729.
@ehsanmok thank you for your contricution!

@SparkQA
Copy link

SparkQA commented Oct 28, 2015

Test build #44541 has finished for PR 9338 at commit edbb1c2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class CrossValidator @Since(\"1.2.0\") (@Since(\"1.2.0\") override val uid: String)\n * class TrainValidationSplit @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)\n

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Nov 12, 2015

@noel-smith could you review it when you have time? Thanks!

@jkbradley
Copy link
Member

@yu-iskw Could you please fix the conflicts?

@noel-smith Will you be able to review this? If not, let me know, and I'll review it.

Thanks!

@noel-smith
Copy link
Contributor

Hi @jkbradley - the version numbers look OK - but I've been unable to get the Scala API docs building in my environment (not just this branch - I get the same problems on master) - so I can't fully verify it.

If you can review it locally - that would probably be quicker in this case.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Nov 25, 2015

Sure. I'll resolve the conflicts by rebaseing master. Just a minute!

@SparkQA
Copy link

SparkQA commented Nov 25, 2015

Test build #46646 has finished for PR 9338 at commit 4b4b14c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public final class SortedIterator extends UnsafeSorterIterator\n * class CrossValidator @Since(\"1.2.0\") (@Since(\"1.2.0\") override val uid: String)\n * class TrainValidationSplit @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)\n

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Nov 25, 2015

@jkbradley I have rebased master.

@noel-smith could you take a look when you have time?

@jkbradley
Copy link
Member

I'll review this now. @noel-smith I generally just look at the spark docs online to do this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uid was added in 1.4 (so same for the constructor)

@jkbradley
Copy link
Member

That should be it!

@jkbradley
Copy link
Member

Ping

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Dec 2, 2015

I'll fix them soon!

@SparkQA
Copy link

SparkQA commented Dec 2, 2015

Test build #47069 has finished for PR 9338 at commit 85be14f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class CrossValidator @Since(\"1.2.0\") (@Since(\"1.4.0\") override val uid: String)\n * class ParamGridBuilder @Since(\"1.2.0\")\n * class TrainValidationSplit @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)\n

asfgit pushed a commit that referenced this pull request Dec 2, 2015
cc mengxr noel-smith

I worked on this issues based on #8729.
ehsanmok  thank you for your contricution!

Author: Yu ISHIKAWA <[email protected]>
Author: Ehsan M.Kermani <[email protected]>

Closes #9338 from yu-iskw/JIRA-10266.

(cherry picked from commit de07d06)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Dec 2, 2015

LGTM. Merged into master and branch-1.6. Thanks!

@asfgit asfgit closed this in de07d06 Dec 2, 2015
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Dec 2, 2015

Thank you for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants