-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-10266][Documentation, ML] Fixed @Since annotation for ml.tunning #9338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #44541 has finished for PR 9338 at commit
|
|
@noel-smith could you review it when you have time? Thanks! |
|
@yu-iskw Could you please fix the conflicts? @noel-smith Will you be able to review this? If not, let me know, and I'll review it. Thanks! |
|
Hi @jkbradley - the version numbers look OK - but I've been unable to get the Scala API docs building in my environment (not just this branch - I get the same problems on master) - so I can't fully verify it. If you can review it locally - that would probably be quicker in this case. |
|
Sure. I'll resolve the conflicts by rebaseing master. Just a minute! |
|
Test build #46646 has finished for PR 9338 at commit
|
|
@jkbradley I have rebased master. @noel-smith could you take a look when you have time? |
|
I'll review this now. @noel-smith I generally just look at the spark docs online to do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uid was added in 1.4 (so same for the constructor)
|
That should be it! |
|
Ping |
|
I'll fix them soon! |
|
Test build #47069 has finished for PR 9338 at commit
|
cc mengxr noel-smith I worked on this issues based on #8729. ehsanmok thank you for your contricution! Author: Yu ISHIKAWA <[email protected]> Author: Ehsan M.Kermani <[email protected]> Closes #9338 from yu-iskw/JIRA-10266. (cherry picked from commit de07d06) Signed-off-by: Xiangrui Meng <[email protected]>
|
LGTM. Merged into master and branch-1.6. Thanks! |
|
Thank you for merging it! |
cc @mengxr @noel-smith
I worked on this issues based on #8729.
@ehsanmok thank you for your contricution!