Skip to content

Add landmark-based Shortest Path algorithm to graphx.lib #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add landmark-based Shortest Path algorithm to graphx.lib #933

wants to merge 5 commits into from

Conversation

@ankurdave
Copy link
Contributor

@ankurdave ankurdave commented Jun 1, 2014

This is a modified version of #10.

@ankurdave
Copy link
Contributor Author

ankurdave commented Jun 1, 2014

@rxin

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15325/

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

Merged build finished.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15335/

andy327 and others added 4 commits June 1, 2014 15:54
@andy327 @ankurdave
Add Shortest-path computations to graphx.lib with unit tests.
60ed8e6 
Adds a landmark-based shortest-path computation to org.apache.spark.graphx.lib.

Author: Andres Perez <[email protected]>
Author: Koert Kuipers <[email protected]>

Closes apache#10 from apache/spark and squashes the following commits:

88d80da [] Merge from master.
c9d1ee8 [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
47e22db [Andres Perez] Remove algebird dependency from ShortestPaths.
44d19e5 [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
4986f80 [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
25fbe10 [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
9ee0d89 [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
745a7a1 [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
9319fac [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
d47865f [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
ba6e530 [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
5c5b197 [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
ee9d90b [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
2d5e788 [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
6cd90a5 [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
2cbfe45 [Koert Kuipers] Merge branch 'master' of https://github.com/apache/spark
a3bdb0e [Koert Kuipers] Merge branch 'master' of https://github.com/apache/incubator-spark
f8f6d91 [Andres Perez] Revert "Add Shortest-path computations to graphx.lib with unit tests."
7496d6b [Andres Perez] Add Shortest-path computations to graphx.lib with unit tests.
@ankurdave
Fix style errors
d983fb4
@ankurdave
Remove unnecessary VD type param, and pass through ED
d75c8fc
@ankurdave
Improve ShortestPaths documentation
7a1ff48
@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

Merged build finished.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 1, 2014

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15336/

@pwendell
Copy link
Contributor

pwendell commented Jun 2, 2014

Jenkins, retest this please.

1 similar comment
@rxin
Copy link
Contributor

rxin commented Jun 2, 2014

Jenkins, retest this please.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 2, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 2, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 2, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 2, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15342/

rxin
rxin reviewed Jun 2, 2014
View reviewed changes
graphx/src/main/scala/org/apache/spark/graphx/lib/ShortestPaths.scala Outdated
Copy link
Contributor

@rxin rxin Jun 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this one? It technically violates our coding style to have a function start with upper case, and confusing to have it the same name as the type itself.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 2, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 2, 2014

Merged build started.

@rxin
Copy link
Contributor

rxin commented Jun 2, 2014

LGTM. Let's merge it once Jenkins is happy.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 2, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 2, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15346/

@rxin
Copy link
Contributor

rxin commented Jun 2, 2014

Thanks. I've merged this in master & branch-1.0.

asfgit pushed a commit that referenced this pull request Jun 2, 2014
@ankurdave @rxin
Add landmark-based Shortest Path algorithm to graphx.lib
af73922 
This is a modified version of #10.

Author: Ankur Dave <[email protected]>
Author: Andres Perez <[email protected]>

Closes #933 from ankurdave/shortestpaths and squashes the following commits:

03a103c [Ankur Dave] Style fixes
7a1ff48 [Ankur Dave] Improve ShortestPaths documentation
d75c8fc [Ankur Dave] Remove unnecessary VD type param, and pass through ED
d983fb4 [Ankur Dave] Fix style errors
60ed8e6 [Andres Perez] Add Shortest-path computations to graphx.lib with unit tests.

(cherry picked from commit 9535f40)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 9535f40 Jun 2, 2014
@CrazyJvm CrazyJvm mentioned this pull request Jun 2, 2014
Merged
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@ankurdave @pdeyhim
Add landmark-based Shortest Path algorithm to graphx.lib
e84aa22 
This is a modified version of apache#10.

Author: Ankur Dave <[email protected]>
Author: Andres Perez <[email protected]>

Closes apache#933 from ankurdave/shortestpaths and squashes the following commits:

03a103c [Ankur Dave] Style fixes
7a1ff48 [Ankur Dave] Improve ShortestPaths documentation
d75c8fc [Ankur Dave] Remove unnecessary VD type param, and pass through ED
d983fb4 [Ankur Dave] Fix style errors
60ed8e6 [Andres Perez] Add Shortest-path computations to graphx.lib with unit tests.
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@ankurdave @conviva-zz
Add landmark-based Shortest Path algorithm to graphx.lib
4d679b9 
This is a modified version of apache#10.

Author: Ankur Dave <[email protected]>
Author: Andres Perez <[email protected]>

Closes apache#933 from ankurdave/shortestpaths and squashes the following commits:

03a103c [Ankur Dave] Style fixes
7a1ff48 [Ankur Dave] Improve ShortestPaths documentation
d75c8fc [Ankur Dave] Remove unnecessary VD type param, and pass through ED
d983fb4 [Ankur Dave] Fix style errors
60ed8e6 [Andres Perez] Add Shortest-path computations to graphx.lib with unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ankurdave @AmplabJenkins @pwendell @rxin @andy327