Skip to content

[SPARK-5966][WIP]<Spark-submit deploy-mode cluster is not compatible with master local> #9220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[SPARK-5966][WIP]<Spark-submit deploy-mode cluster is not compatible with master local> #9220

wants to merge 3 commits into from

Conversation

@kevinyu98
Copy link
Contributor

@kevinyu98 kevinyu98 commented Oct 22, 2015

… master local>

@kevinyu98 kevinyu98 changed the title [SPARK-5966]<Spark-submit deploy-mode cluster is not compatible with … [SPARK-5966][WIP]<Spark-submit deploy-mode cluster is not compatible with master local> Oct 22, 2015
@srowen
Copy link
Member

srowen commented Oct 22, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Oct 22, 2015

Test build #1938 has finished for PR 9220 at commit 396c66a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

andrewor14
andrewor14 reviewed Oct 22, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala Outdated
Copy link
Contributor

@andrewor14 andrewor14 Oct 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a place down there (L321) where we do checks like this. Please move it down there to be more consistent

Copy link
Contributor Author

@kevinyu98 kevinyu98 Oct 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Andrew: Thanks for pointing this out, I have made the code changes, run the test , and submit the pull request, can you help review?
Kevin

JoshRosen
JoshRosen reviewed Oct 22, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/impatient.sc Outdated
Copy link
Contributor

@JoshRosen JoshRosen Oct 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? Unintentional?

Copy link
Contributor Author

@kevinyu98 kevinyu98 Oct 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Josh: Sorry, it is unintentional. I have deleted the new file and push again.

@andrewor14
Copy link
Contributor

andrewor14 commented Oct 23, 2015

retest this please

@andrewor14
Copy link
Contributor

andrewor14 commented Oct 23, 2015

LGTM, will merge once tests pass.

andrewor14
andrewor14 reviewed Oct 23, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
Copy link
Contributor

@andrewor14 andrewor14 Oct 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm going to nix this blank line when I merge (no action required on your part)

@SparkQA
Copy link

SparkQA commented Oct 23, 2015

Test build #44252 has finished for PR 9220 at commit dc75828.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Oct 26, 2015
@kevinyu98 @srowen
[SPARK-5966][WIP] Spark-submit deploy-mode cluster is not compatible …
a355d0d 
…with master local>

… master local>

Author: Kevin Yu <[email protected]>

Closes #9220 from kevinyu98/working_on_spark-5966.

(cherry picked from commit 616be29)
Signed-off-by: Sean Owen <[email protected]>
@srowen
Copy link
Member

srowen commented Oct 26, 2015

Merged to master/1.5 (after removing that blank line)

@asfgit asfgit closed this in 616be29 Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kevinyu98 @srowen @SparkQA @andrewor14 @JoshRosen