Skip to content

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Oct 20, 2015

…rint in python

No test needed. Verify it manually in pyspark shell

@SparkQA
Copy link

SparkQA commented Oct 20, 2015

Test build #43972 has finished for PR 9177 at commit e4417c8.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

While I agree that it would be nice to have both outputs match, I'm not sure that this is the right way to do it. After your change, the output is being printed by a separate process, breaking the tests and possibly breaking this feature for certain environments where the Py4J Gateway JVM's stdout / stderr isn't captured or display.

If you still want to fix this, can you come up with an approach which prints the header in Python or otherwise harmonizes the output without changing which process performs the printing?

@rxin
Copy link
Contributor

rxin commented Oct 20, 2015

I think this would break a lot of things, including output redirection in Python.

@rxin
Copy link
Contributor

rxin commented Oct 21, 2015

@zjffdu mind closing this pull request?

@zjffdu
Copy link
Contributor Author

zjffdu commented Oct 21, 2015

@rxin I will make a new commit soon to match the output in python and scala. Should be a trivial change.

@SparkQA
Copy link

SparkQA commented Oct 21, 2015

Test build #44044 has finished for PR 9177 at commit 39f3fc0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Oct 21, 2015

Can you show the before and after changes?

@JoshRosen
Copy link
Contributor

@rxin, I believe that the doctest itself reflects the before/after.

@rxin
Copy link
Contributor

rxin commented Oct 21, 2015

Thanks - I've merged this.

@asfgit asfgit closed this in 5cdea7d Oct 21, 2015
@zjffdu zjffdu changed the title [SPARK-11205] [PYSPARK] Delegate to scala DataFrame API rather than p… [SPARK-11205] [PYSPARK] Match the output of DataFrame#explain() in both scala api and python Oct 21, 2015
@zjffdu
Copy link
Contributor Author

zjffdu commented Oct 21, 2015

Sorry, @rxin forget to change the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants