[SPARK-11084][ML][PYTHON] Check if index can contain non-zero value before binary search #9098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero323
force-pushed
the
sparse_vector_getitem_improved
branch
from
7f1e455 to
31c192e
Compare
Member
There was a problem hiding this comment.
Curious: Is inds.item(-1) faster than inds[-1]? I wasn't sure.
Member
Author
There was a problem hiding this comment.
By itself it is slower than using __getitem__ but it returns standard Python scalar and overall it should be marginally faster when index is a standard scalar as well.
If you think that inds[-1] is better it shouldn't really matter. With crude tests I get ~40 ns difference on average (245 ns for [] and, 205 ns for inds)
Member
There was a problem hiding this comment.
Sounds good, I'd keep what you have.
Member
|
Thanks for the PR! |
|
Test build #1900 has finished for PR 9098 at commit
|
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment
SparseVector.__getitem__executesnp.searchsortedfirst and checks if result is in an expected range after that. It is possible to check if index can contain non-zero value before executingnp.searchsorted.