[SPARK-11036][SQL] AttributeReference should not be assigned new expression id inside tasks

[viirya]

JIRA: https://issues.apache.org/jira/browse/SPARK-11036

Related to #9093, SPARK-11036 is proposed to not allow AttributeReference to be created in executors. #9093 solves part of SPARK-11036. But the method withExprId will possibly assign new expression id to AttributeReference too. This patch tries to prevent that by using the same mechanism of #9093.

[SparkQA]

Test build #43636 has finished for PR 9094 at commit 3df9212.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[davies]

@viirya Since the newExprId is created in driver, I think it's OK to call withExprId in tasks. #9093 should be enough to fix SPARK-11036, I will close that as duplicated.

[viirya]

@davies Indeed. Looks like exprId given to withExprId is from other Attribute and is not created in tasks. I close this now.