Skip to content

Conversation

@BryanCutler
Copy link
Member

…rain with given regParam and StreamingLinearRegressionWithSGD intercept param is not in correct position.

regParam was being passed into the StreamingLogisticRegressionWithSGD constructor, but not transferred to the call for model training. The param is added as a named argument to the call. For StreamingLinearRegressionWithSGC the intercept parameter was not in the correct position and was being passed in as the regularization value.

…rain with given regParam and StreamingLinearRegressionWithSGD intercept param is not in correct position
@SparkQA
Copy link

SparkQA commented Oct 13, 2015

Test build #43614 has finished for PR 9087 at commit e97e691.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@BryanCutler
Copy link
Member Author

test this please

@SparkQA
Copy link

SparkQA commented Oct 13, 2015

Test build #43617 has finished for PR 9087 at commit 8b4eb08.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Oct 13, 2015
…rain with given regParam and StreamingLinearRegressionWithSGD intercept param is not in correct position.

regParam was being passed into the StreamingLogisticRegressionWithSGD constructor, but not transferred to the call for model training. The param is added as a named argument to the call.  For StreamingLinearRegressionWithSGC the intercept parameter was not in the correct position and was being passed in as the regularization value.

Author: Bryan Cutler <[email protected]>

Closes #9087 from BryanCutler/StreamingSGD-convergenceTol-bug-10959-branch-1.5.
@mengxr
Copy link
Contributor

mengxr commented Oct 13, 2015

Merged into branch-1.5. Could you close this PR manually? The merge script only closes PRs sent to the master branch. Thanks!

@BryanCutler BryanCutler deleted the StreamingSGD-convergenceTol-bug-10959-branch-1.5 branch November 18, 2015 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants