[SPARK-10959] [PySpark] StreamingLogisticRegressionWithSGD does not train with given regParam and convergenceTol parameters #9002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th SGD to pass in convergenceTol or regularization to training
BryanCutler
changed the title
BryanCutler
changed the title
Contributor
|
add to whitelist |
Contributor
|
ok to test |
Contributor
|
LGTM pending Jenkins. |
Contributor
|
test this please |
|
Test build #43398 has finished for PR 9002 at commit
|
Contributor
|
Merged into master and branch-1.5. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Oct 9, 2015
…rain with given regParam and convergenceTol parameters These params were being passed into the StreamingLogisticRegressionWithSGD constructor, but not transferred to the call for model training. Same with StreamingLinearRegressionWithSGD. I added the params as named arguments to the call and also fixed the intercept parameter, which was being passed as regularization value. Author: Bryan Cutler <[email protected]> Closes #9002 from BryanCutler/StreamingSGD-convergenceTol-bug-10959. (cherry picked from commit 5410747) Signed-off-by: Xiangrui Meng <[email protected]>
Member
|
This shouldn't have been backported to 1.5 since 1.5 did not have convergenceTol. I'll revert the 1.5 change. @BryanCutler Would you mind preparing a separate backport for 1.5 which just handles regParam? Thanks! See failure: |
Member
|
Reverted in commit: [https://github.com/apache/spark/commit/2217f4f8b8fa6ad8b0b7200591a5e7c827cb6e18] |
Member
Author
|
sure, no problem @jkbradley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These params were being passed into the StreamingLogisticRegressionWithSGD constructor, but not transferred to the call for model training. Same with StreamingLinearRegressionWithSGD. I added the params as named arguments to the call and also fixed the intercept parameter, which was being passed as regularization value.