[SPARK-10932] [PROJECT INFRA] Port two minor changes to release-build.sh from scripts' old repo #8986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshRosen
changed the title
JoshRosen
changed the title
Contributor
|
Can we add some code here to check the return code of |
Contributor
Author
|
@shivaram, good idea. Note, however, that the build that was used to publish the 0.5.1 binary releases did actually fail in Jenkins. Aside from adding additional return code checks, do these changes of yours look fine to pull into Spark's version of this script? |
|
Test build #43248 has finished for PR 8986 at commit
|
Contributor
|
Ah I see - didn't know it was failing Jenkins as well. |
Contributor
Author
|
Going to merge this now so that it doesn't become stale or get forgotten. I'll address return code checks if the problem re-occurs once we're closer to the release. |
asfgit
pushed a commit
that referenced
this pull request
Oct 13, 2015
….sh from scripts' old repo Spark's release packaging scripts used to live in a separate repository. Although these scripts are now part of the Spark repo, there are some minor patches made against the old repos that are missing in Spark's copy of the script. This PR ports those changes. /cc shivaram, who originally submitted these changes against https://github.com/rxin/spark-utils Author: Josh Rosen <[email protected]> Closes #8986 from JoshRosen/port-release-build-fixes-from-rxin-repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark's release packaging scripts used to live in a separate repository. Although these scripts are now part of the Spark repo, there are some minor patches made against the old repos that are missing in Spark's copy of the script. This PR ports those changes.
/cc @shivaram, who originally submitted these changes against https://github.com/rxin/spark-utils