Skip to content

[SPARK-10737] [SQL] When using UnsafeRows, SortMergeJoin may return wrong results #8854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-10737] [SQL] When using UnsafeRows, SortMergeJoin may return wrong results #8854

wants to merge 1 commit into from

Conversation

@yhuai
Copy link
Contributor

@yhuai yhuai commented Sep 21, 2015

@SparkQA
Copy link

SparkQA commented Sep 21, 2015

Test build #42783 has finished for PR 8854 at commit 5bff8dc.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

marmbrus
marmbrus reviewed Sep 21, 2015
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala Outdated
Copy link
Contributor

@marmbrus marmbrus Sep 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these use the objects so there will be a compile error if we ever remove these options? (and then we can delete this test)

Copy link
Contributor Author

@yhuai yhuai Sep 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@SparkQA
Copy link

SparkQA commented Sep 22, 2015

Test build #42789 has finished for PR 8854 at commit 3c8f8cb.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor Author

yhuai commented Sep 22, 2015

jenkins test this please

@SparkQA
Copy link

SparkQA commented Sep 22, 2015

Test build #42790 has finished for PR 8854 at commit 3a948d2.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 22, 2015

Test build #42798 has finished for PR 8854 at commit 5406680.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 22, 2015

Test build #42809 has finished for PR 8854 at commit 55d4f9a.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai
Copy link
Contributor Author

yhuai commented Sep 22, 2015

test this please

@SparkQA
Copy link

SparkQA commented Sep 22, 2015

Test build #42816 has finished for PR 8854 at commit 55d4f9a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@marmbrus
Copy link
Contributor

marmbrus commented Sep 22, 2015

LGTM

@yhuai
Copy link
Contributor Author

yhuai commented Sep 22, 2015

@JoshRosen Can you also take a look?

@JoshRosen
Copy link
Contributor

JoshRosen commented Sep 22, 2015

LGTM.

@yhuai
Copy link
Contributor Author

yhuai commented Sep 22, 2015

Thank you for reviewing this PR! I am merging it to master and branch 1.5.

asfgit pushed a commit that referenced this pull request Sep 22, 2015
@yhuai
[SPARK-10737] [SQL] When using UnsafeRows, SortMergeJoin may return w…
6b1e5c2 
…rong results

https://issues.apache.org/jira/browse/SPARK-10737

Author: Yin Huai <[email protected]>

Closes #8854 from yhuai/SMJBug.

(cherry picked from commit 5aea987)
Signed-off-by: Yin Huai <[email protected]>
@asfgit asfgit closed this in 5aea987 Sep 22, 2015
ashangit pushed a commit to ashangit/spark that referenced this pull request Oct 19, 2016
@yhuai
[SPARK-10737] [SQL] When using UnsafeRows, SortMergeJoin may return w…
2a30245 
…rong results

https://issues.apache.org/jira/browse/SPARK-10737

Author: Yin Huai <[email protected]>

Closes apache#8854 from yhuai/SMJBug.

(cherry picked from commit 5aea987)
Signed-off-by: Yin Huai <[email protected]>
(cherry picked from commit 6b1e5c2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yhuai @SparkQA @marmbrus @JoshRosen