[Doc][PySpark][MLLib] Added newlines to docstrings to fix parameter formatting #8851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. Thanks for fixing this! |
|
Test build #42770 has finished for PR 8851 at commit
|
Contributor
|
Merged into master. Thanks! I also tried branch-1.5 but it has some merge conflicts. It would be nice to backport the changes to branch-1.5 before Spark 1.5.1 release. @noel-smith Could you try it? |
Contributor
Author
|
Sure - should be straightforward, I'll take a look. |
asfgit
pushed a commit
that referenced
this pull request
Sep 22, 2015
… formatting (1.5 backport) Backport of #8851 for 1.5 branch. Author: noelsmith <[email protected]> Closes #8855 from noel-smith/docstring-missing-newline-fix-1-5-backport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added newlines before
:param ...:and:return:markup. Without these, parameter lists aren't formatted correctly in the API docs. I.e:.. looks like this once newline is added: