[SPARK-10539][SQL]Project should not be pushed down through Intersect or Except #8742 #8823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The fix is good. I only added comments. Will merge it to both master and branch 1.5 once it passes jenkins. |
|
Test build #42675 has finished for PR 8823 at commit
|
Contributor
Author
|
Merging to master and branch 1.5. Thanks @yjshen |
asfgit
pushed a commit
that referenced
this pull request
Sep 18, 2015
…ct or Except #8742 Intersect and Except are both set operators and they use the all the columns to compare equality between rows. When pushing their Project parent down, the relations they based on would change, therefore not an equivalent transformation. JIRA: https://issues.apache.org/jira/browse/SPARK-10539 I added some comments based on the fix of #8742. Author: Yijie Shen <[email protected]> Author: Yin Huai <[email protected]> Closes #8823 from yhuai/fix_set_optimization. (cherry picked from commit c6f8135) Signed-off-by: Yin Huai <[email protected]> Conflicts: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
ashangit
pushed a commit
to ashangit/spark
that referenced
this pull request
Oct 19, 2016
…ct or Except apache#8742 Intersect and Except are both set operators and they use the all the columns to compare equality between rows. When pushing their Project parent down, the relations they based on would change, therefore not an equivalent transformation. JIRA: https://issues.apache.org/jira/browse/SPARK-10539 I added some comments based on the fix of apache#8742. Author: Yijie Shen <[email protected]> Author: Yin Huai <[email protected]> Closes apache#8823 from yhuai/fix_set_optimization. (cherry picked from commit c6f8135) Signed-off-by: Yin Huai <[email protected]> Conflicts: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala (cherry picked from commit 3df52cc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intersect and Except are both set operators and they use the all the columns to compare equality between rows. When pushing their Project parent down, the relations they based on would change, therefore not an equivalent transformation.
JIRA: https://issues.apache.org/jira/browse/SPARK-10539
I added some comments based on the fix of #8742.