[SPARK-10540] Fixes flaky all-data-type test #8768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #42488 has finished for PR 8768 at commit
|
Contributor
|
Can we let every test run more times (50 or 100 times) before we merge it? |
Contributor
Author
|
@yhuai OK, I'll make a temporary commit to trigger such a Jenkins build and revert it later. |
Contributor
Author
|
@yhuai BTW, I did try to run every test 100 times locally, and it works. |
Contributor
|
oh, then it is fine. We can revert the temp commit and test it again. Once jenkins passes, we can merge it. |
|
Test build #42624 has finished for PR 8768 at commit
|
This reverts commit 9c4fee1.
Contributor
|
LGTM. Once jenkins is good, I will merge it to master and branch 1.5. |
|
Test build #42671 has finished for PR 8768 at commit
|
Contributor
|
Thanks! Merging. |
asfgit
pushed a commit
that referenced
this pull request
Sep 18, 2015
This PR breaks the original test case into multiple ones (one test case for each data type). In this way, test failure output can be much more readable. Within each test case, we build a table with two columns, one of them is for the data type to test, the other is an "index" column, which is used to sort the DataFrame and workaround [SPARK-10591] [1] [1]: https://issues.apache.org/jira/browse/SPARK-10591 Author: Cheng Lian <[email protected]> Closes #8768 from liancheng/spark-10540/test-all-data-types. (cherry picked from commit 00a2911) Signed-off-by: Yin Huai <[email protected]>
ashangit
pushed a commit
to ashangit/spark
that referenced
this pull request
Oct 19, 2016
This PR breaks the original test case into multiple ones (one test case for each data type). In this way, test failure output can be much more readable. Within each test case, we build a table with two columns, one of them is for the data type to test, the other is an "index" column, which is used to sort the DataFrame and workaround [SPARK-10591] [1] [1]: https://issues.apache.org/jira/browse/SPARK-10591 Author: Cheng Lian <[email protected]> Closes apache#8768 from liancheng/spark-10540/test-all-data-types. (cherry picked from commit 00a2911) Signed-off-by: Yin Huai <[email protected]> (cherry picked from commit e1e781f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks the original test case into multiple ones (one test case for each data type). In this way, test failure output can be much more readable.
Within each test case, we build a table with two columns, one of them is for the data type to test, the other is an "index" column, which is used to sort the DataFrame and workaround SPARK-10591