[SPARK-10573] [ML] IndexToString output schema should be StringType #8751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ok to test |
Contributor
|
LGTM pending Jenkins. |
|
Test build #42435 has finished for PR 8751 at commit
|
Contributor
|
LGTM. Merged into master and branch-1.5. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Sep 14, 2015
Fixes bug where IndexToString output schema was DoubleType. Correct me if I'm wrong, but it doesn't seem like the output needs to have any "ML Attribute" metadata. Author: Nick Pritchard <[email protected]> Closes #8751 from pnpritchard/SPARK-10573. (cherry picked from commit 8a634e9) Signed-off-by: Xiangrui Meng <[email protected]>
ashangit
pushed a commit
to ashangit/spark
that referenced
this pull request
Oct 19, 2016
Fixes bug where IndexToString output schema was DoubleType. Correct me if I'm wrong, but it doesn't seem like the output needs to have any "ML Attribute" metadata. Author: Nick Pritchard <[email protected]> Closes apache#8751 from pnpritchard/SPARK-10573. (cherry picked from commit 8a634e9) Signed-off-by: Xiangrui Meng <[email protected]> (cherry picked from commit 5b7067c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where IndexToString output schema was DoubleType. Correct me if I'm wrong, but it doesn't seem like the output needs to have any "ML Attribute" metadata.