Skip to content

[SPARK-10564] ThreadingSuite: assertion failures in threads don't fail the test (round 2) #8727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-10564] ThreadingSuite: assertion failures in threads don't fail the test (round 2) #8727

wants to merge 1 commit into from

Conversation

@andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Sep 11, 2015

This is a follow-up patch to #8723. I missed one case there.

@SparkQA
Copy link

SparkQA commented Sep 12, 2015

Test build #42363 has finished for PR 8727 at commit ddc9b24.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class IntersectNode(conf: SQLConf, left: LocalNode, right: LocalNode)
    • case class SampleNode(
    • case class TakeOrderedAndProjectNode(

@andrewor14
Copy link
Contributor Author

andrewor14 commented Sep 14, 2015

retest this please

@andrewor14
Copy link
Contributor Author

andrewor14 commented Sep 14, 2015

This already passed ThreadingSuite. Merging into master.

@asfgit asfgit closed this in 7b6c856 Sep 14, 2015
asfgit pushed a commit that referenced this pull request Sep 14, 2015
[SPARK-10564] ThreadingSuite: assertion failures in threads don't fai…
5db51f9 
…l the test (round 2)

This is a follow-up patch to #8723. I missed one case there.

Author: Andrew Or <[email protected]>

Closes #8727 from andrewor14/fix-threading-suite.

(cherry picked from commit 7b6c856)
Signed-off-by: Andrew Or <[email protected]>
@SparkQA
Copy link

SparkQA commented Sep 14, 2015

Test build #42449 has finished for PR 8727 at commit ddc9b24.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14 andrewor14 deleted the fix-threading-suite branch September 15, 2015 18:10
ashangit pushed a commit to ashangit/spark that referenced this pull request Oct 19, 2016
[SPARK-10564] ThreadingSuite: assertion failures in threads don't fai…
d458e78 
…l the test (round 2)

This is a follow-up patch to apache#8723. I missed one case there.

Author: Andrew Or <[email protected]>

Closes apache#8727 from andrewor14/fix-threading-suite.

(cherry picked from commit 7b6c856)
Signed-off-by: Andrew Or <[email protected]>
(cherry picked from commit 5db51f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewor14 @SparkQA