SPARK-10546 Check partitionId's range in ExternalSorter#spill()

[tedyu]

See this thread for background:
http://search-hadoop.com/m/q3RTt0rWvIkHAE81

We should check the range of partition Id and provide meaningful message through exception.

Alternatively, we can use abs() and modulo to force the partition Id into legitimate range. However, expectation is that user should correct the logic error in his / her code.

[SparkQA]

Test build #42280 has finished for PR 8703 at commit 63dfe11.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[andrewor14]

please file JIRA

[SparkQA]

Test build #42287 has finished for PR 8703 at commit 04aa45e.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Can you just use one require statement to make this more compact? and string interpolation

[SparkQA]

Test build #42333 has finished for PR 8703 at commit 0e86ae8.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

LGTM

[SparkQA]

Test build #42338 has finished for PR 8703 at commit a293906.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.