Skip to content

Conversation

@teramonagi
Copy link
Contributor

No description provided.

@shivaram
Copy link
Contributor

@teramonagi Could you clarify what these profiles are meant to be ? Are they IAM profiles or something else ?

cc @nchammas

@teramonagi
Copy link
Contributor Author

@shivaram
"profiles" give us the way that you can specify the set of credentials you want to use when you initialize a connection to AWS.

You can keep multiple sets of credentials in the same credentials files using different profile names.
For example, you can use --profile option to do that when you use "aws cli tool".

(Search the word "--profile" on the abobe link)

@teramonagi teramonagi changed the title [SPARK-10532][EC2]Added --profile option to specify names profiles [SPARK-10532][EC2]Added --profile option to specify the name of profile Sep 12, 2015
@neil-rubens
Copy link

ec2/spark_ec2.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand this to explain what type of profile this is talking about? Like, maybe clarify whether it's an IAM or boto profile or whatever? As it stands now, I worry that this description isn't clear to people unfamiliar with this feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually speaking, we can use any types of profile(AWS/boto). The remaining problem is just the loading order of these "profiles" as Jan Vlcinsky explained. I think that it is little bit long to explain that in commandline help.

I adde little modification(aws or boto config) in that help.

ec2/spark_ec2.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if I wanted to have a profile that's named "default"? I think it would better to have None as the default and to replace this with an is not None check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I will fix this quickly

@JoshRosen
Copy link
Contributor

This seems reasonable to me. Might be nice to have @nchammas take a quick peek. If I don't hear otherwise, I'll merge this by Monday.

@nchammas
Copy link
Contributor

LGTM. I would update the PR description though so when this gets merged in the commit message has the rationale behind this change.

@JoshRosen
Copy link
Contributor

Jenkins, this is ok to test.

@JoshRosen
Copy link
Contributor

I'm going to run the Python style checker, then will merge this and update the PR description myself. Thanks @teramonagi.

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Oct 20, 2015

Test build #44004 has finished for PR 8696 at commit 5152fa4.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@teramonagi
Copy link
Contributor Author

@JihongMA Thanks a lot Josh!!!

@asfgit asfgit closed this in f21ef8d Oct 29, 2015
@teramonagi teramonagi deleted the SPARK-10532 branch October 29, 2015 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants