[SPARK-7874][MESOS] Don’t allocate more than spark.cores.max in fine-grained mode. #8671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #42206 has finished for PR 8671 at commit
|
dragos
force-pushed
the
issue/mesos/fine-grained-maxCores
branch
from
deca1d3 to
6f748c5
Compare
|
Test build #42207 has finished for PR 8671 at commit
|
Contributor
Author
|
/cc @tnachen @andrewor14 |
Contributor
Author
|
@tnachen @andrewor14 would you have some time to have a look at this one? |
Contributor
There was a problem hiding this comment.
Will availableCores becomes negative and just starts adding actual Cores?
I think it's probably safer to check if availableCores < Cores then we just return None.
Contributor
Author
There was a problem hiding this comment.
Ok, I'll refactor this condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only coarse-grained mode observes
spark.cores.max. The fine-grained mode should follow the same limit, and not go above the defined maximum cores.There's some duplication of logic between the coarse-grained and fine-grained mode. I created SPARK-10444 to fix that.