[SPARK-6931] [PYSPARK] Cast Python time float values to int before serialization #8594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Jenkins, this is ok to test. |
|
Test build #41987 has finished for PR 8594 at commit
|
Member
Author
|
Looks like the style, tests, and mima passed, I'm not sure why it was marked as Failed.. |
Contributor
|
Jenkins, retest this please. |
|
Test build #42049 has finished for PR 8594 at commit
|
|
Test FAILed. |
Contributor
|
LGTM, merging into 1.2 and 1.3, thanks! |
asfgit
pushed a commit
that referenced
this pull request
Sep 10, 2015
…rialization
Python time values return a floating point value, need to cast to integer before serialize with struct.pack('!q', value)
https://issues.apache.org/jira/browse/SPARK-6931
Author: Bryan Cutler <[email protected]>
Closes #8594 from BryanCutler/py-write_long-backport-6931-1.2.
asfgit
pushed a commit
that referenced
this pull request
Sep 10, 2015
…rialization
Python time values return a floating point value, need to cast to integer before serialize with struct.pack('!q', value)
https://issues.apache.org/jira/browse/SPARK-6931
Author: Bryan Cutler <[email protected]>
Closes #8594 from BryanCutler/py-write_long-backport-6931-1.2.
(cherry picked from commit 4862a80)
Signed-off-by: Davies Liu <[email protected]>
Contributor
|
@BryanCutler This is not get closed automatically, could you close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python time values return a floating point value, need to cast to integer before serialize with struct.pack('!q', value)
https://issues.apache.org/jira/browse/SPARK-6931