Skip to content

[SPARK-10402][DOCS][ML] Add defaults to the scaladoc for params in ml/ #8591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-10402][DOCS][ML] Add defaults to the scaladoc for params in ml/ #8591

wants to merge 2 commits into from

Conversation

@holdenk
Copy link
Contributor

@holdenk holdenk commented Sep 3, 2015

We should make sure the scaladoc for params includes their default values through the models in ml/

@SparkQA
Copy link

SparkQA commented Sep 3, 2015

Test build #41982 has finished for PR 8591 at commit 8f49cf5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jkbradley
jkbradley reviewed Sep 4, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluator.scala Outdated
Copy link
Member

@jkbradley jkbradley Sep 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already says the default 2 lines above. Keep only one statement of the default.

@jkbradley
Copy link
Member

jkbradley commented Sep 4, 2015

LGTM pending tests

@SparkQA
Copy link

SparkQA commented Sep 4, 2015

Test build #42021 has finished for PR 8591 at commit 16c972e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

jkbradley commented Sep 5, 2015

Merging with master and branch-1.5

asfgit pushed a commit that referenced this pull request Sep 5, 2015
@holdenk @jkbradley
[SPARK-10402] [DOCS] [ML] Add defaults to the scaladoc for params in ml/
cfc5f6f 
We should make sure the scaladoc for params includes their default values through the models in ml/

Author: Holden Karau <[email protected]>

Closes #8591 from holdenk/SPARK-10402-add-scaladoc-for-default-values-of-params-in-ml.

(cherry picked from commit 22eab70)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in 22eab70 Sep 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@holdenk @SparkQA @jkbradley