[SPARK-10377] [SQL] [BRANCH-1.4] Rename TakeOrderedAndProject back to TakeOrdered. #8545
Conversation
|
@frodeso This is the change to rename it back. |
yhuai
changed the title
|
Test build #41851 has finished for PR 8545 at commit
|
|
I believe that we've also made other strategy renames in recent patches, including a rename of the join selection strategy (it's no longer called HashJoinStrategy). Does this imply that we need to change that name back as well? |
|
Is that in branch 1.4? Looks like we still have |
|
Ah, gotcha. They're still going to have to update for 1.5, though, and will need to use reflection if they want to be compatible across 1.4.x and 1.5.x (or ship multiple versions of their library). |
|
Yeah, I think it makes sense to update their lib since those Strategies used by our planner are all private APIs. |
|
@cloud-fan I did a quick of their repo. Looks like they have their own SQLContext and refer to the |
|
@cloud-fan @yhuai I just did the same and came to the same conclusion. We are not actually involved in the connector, just a user of it so no guarantees though. Thanks for the quick response! |
… TakeOrdered. https://issues.apache.org/jira/browse/SPARK-10377 #8252 (comment) renames `TakeOrdered` to `TakeOrderedAndProject` (this is an internal API), which breaks third-party code using Spark 1.4 branch (e.g. Cassandra connector https://github.com/datastax/spark-cassandra-connector/blob/v1.4.0-M3/spark-cassandra-connector/src/main/scala/org/apache/spark/sql/cassandra/CassandraSQLContext.scala#L90). This PR renames this class back to `TakeOrdered`. Author: Yin Huai <[email protected]> Closes #8545 from yhuai/SPARK-10377.
|
@frodeso This one has been merged. When we release 1.4.2, the name of that strategy will be the same. |
|
@yhuai Thanks, much appreciated! |
5 participants
https://issues.apache.org/jira/browse/SPARK-10377
#8252 (comment) renames
TakeOrderedtoTakeOrderedAndProject(this is an internal API), which breaks third-party code using Spark 1.4 branch (e.g. Cassandra connector https://github.com/datastax/spark-cassandra-connector/blob/v1.4.0-M3/spark-cassandra-connector/src/main/scala/org/apache/spark/sql/cassandra/CassandraSQLContext.scala#L90). This PR renames this class back toTakeOrdered.