Skip to content

[SPARK-10264][Documentation, ML] Added Since annotation for ml.recomendation #8532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[SPARK-10264][Documentation, ML] Added Since annotation for ml.recomendation #8532

wants to merge 8 commits into from

Conversation

@tijoparacka
Copy link

@tijoparacka tijoparacka commented Aug 31, 2015

Added Since annotation for ALS.scala

feynmanliang
feynmanliang reviewed Aug 31, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala Outdated
Copy link
Contributor

@feynmanliang feynmanliang Aug 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please annotate auxillary constructor

Copy link
Author

@tijoparacka tijoparacka Sep 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Auxiliary constructor

@feynmanliang
Copy link
Contributor

feynmanliang commented Aug 31, 2015

Made a pass

@feynmanliang
Copy link
Contributor

feynmanliang commented Sep 1, 2015

LGTM

mengxr
mengxr reviewed Sep 1, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala Outdated
Copy link
Contributor

@mengxr mengxr Sep 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document public params in the constructor. Though the constructor is private, those variables are public.

    @Since("1.4.0") override val uid: String,
    @Since("1.4.0") override val rank: Int

@tijoparacka
Copy link
Author

tijoparacka commented Oct 1, 2015

Any of you can review this and merge. I may loose track if it is delayed more.

@mengxr
Copy link
Contributor

mengxr commented Oct 20, 2015

ok to test

mengxr
mengxr reviewed Oct 20, 2015
View reviewed changes
mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
Copy link
Contributor

@mengxr mengxr Oct 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need @Since annotation for developer APIs.

@SparkQA
Copy link

SparkQA commented Oct 21, 2015

Test build #44015 has finished for PR 8532 at commit 7b65e62.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class ALS(@Since(\"1.4.0\") override val uid: String) extends Estimator[ALSModel] with ALSParams\n * case class Rating[@specialized(Int, Long) ID] @Since(\"1.3.0\")(\n

@jkbradley
Copy link
Member

jkbradley commented Nov 23, 2015

@tijoparacka Ping! Could you please update this based on @mengxr 's comments and also fix the merge conflicts? Thank you!

@srowen
Copy link
Member

srowen commented Jan 13, 2016

Close this PR please @tijoparacka if you're not updating it

@srowen srowen mentioned this pull request Jan 14, 2016
Closed
@asfgit asfgit closed this in ef8fb36 Jan 25, 2016
@mengxr
Copy link
Contributor

mengxr commented Jan 25, 2016

I closed this PR. The feature is implemented in #10756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tijoparacka @feynmanliang @mengxr @SparkQA @jkbradley @srowen