[SPARK-10354] [MLLIB] fix some apparent memory issues in k-means|| initializaiton #8526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…do not wrap Vector
Contributor
Author
There was a problem hiding this comment.
not calling BLAS here because runs == 1 in most cases
|
Test build #41801 has finished for PR 8526 at commit
|
Contributor
|
The fix reduces around 50G RDD based on data size below. The performance is improved. The user needs more than 8G memory to run the kmeans in Spark1.5 based on this data size. The data size: |
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Aug 31, 2015
…nitializaiton * do not cache first cost RDD * change following cost RDD cache level to MEMORY_AND_DISK * remove Vector wrapper to save a object per instance Further improvements will be addressed in SPARK-10329 cc: yu-iskw HuJiayin Author: Xiangrui Meng <[email protected]> Closes #8526 from mengxr/SPARK-10354. (cherry picked from commit f0f563a) Signed-off-by: Xiangrui Meng <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Aug 31, 2015
…nitializaiton * do not cache first cost RDD * change following cost RDD cache level to MEMORY_AND_DISK * remove Vector wrapper to save a object per instance Further improvements will be addressed in SPARK-10329 cc: yu-iskw HuJiayin Author: Xiangrui Meng <[email protected]> Closes #8526 from mengxr/SPARK-10354. (cherry picked from commit f0f563a) Signed-off-by: Xiangrui Meng <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Aug 31, 2015
…nitializaiton * do not cache first cost RDD * change following cost RDD cache level to MEMORY_AND_DISK * remove Vector wrapper to save a object per instance Further improvements will be addressed in SPARK-10329 cc: yu-iskw HuJiayin Author: Xiangrui Meng <[email protected]> Closes #8526 from mengxr/SPARK-10354. (cherry picked from commit f0f563a) Signed-off-by: Xiangrui Meng <[email protected]>
mengxr
changed the title
Contributor
Author
|
@hujiayin Thanks for testing! Merged into master, branch-1.5, 1.4, and 1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further improvements will be addressed in SPARK-10329
cc: @yu-iskw @hujiayin