Skip to content

Conversation

@yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Aug 25, 2015

cc: @shivaram

Summary

  • Add @name tags to each methods in DataFrame.R and column.R
  • Replace @rdname column with @rdname {each_func}. i.e. alias method : @rdname column => @rdname alias

Generated PDF File

https://drive.google.com/file/d/0B9biIZIU47lLNHN2aFpnQXlSeGs/view?usp=sharing

JIRA

[SPARK-10214] Improve SparkR Column, DataFrame API docs - ASF JIRA

@yu-iskw yu-iskw changed the title [SPARK-10214][SparkR][Docs] [SPARK-10214][SparkR][Docs] Improve SparkR Column, DataFrame API docs Aug 25, 2015
@shivaram
Copy link
Contributor

@yu-iskw I don't seem to have permission to access the google drive PDF ?

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Aug 25, 2015

@shivaram sorry, I modified the permission.

@shivaram
Copy link
Contributor

From the PDF it looks like there are 3 or 4 more such methods: I could spot cache, count, describe, printSchema and show -- Or are these different for some reason I have missed ?

@shivaram
Copy link
Contributor

Also one more minor thing is that the DataFrame-class somehow has details about the agg methods. I am not sure why that happened though

@SparkQA
Copy link

SparkQA commented Aug 25, 2015

Test build #41524 has finished for PR 8414 at commit b7542c1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Aug 25, 2015

It's my fault. I have fixed them.

@shivaram
Copy link
Contributor

LGTM. Will merge once Jenkins passes

@SparkQA
Copy link

SparkQA commented Aug 25, 2015

Test build #41525 has finished for PR 8414 at commit 0a3f176.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in d4549fe Aug 25, 2015
asfgit pushed a commit that referenced this pull request Aug 25, 2015
cc: shivaram

## Summary

- Add name tags to each methods in DataFrame.R and column.R
- Replace `rdname column` with `rdname {each_func}`. i.e. alias method : `rdname column` =>  `rdname alias`

## Generated PDF File
https://drive.google.com/file/d/0B9biIZIU47lLNHN2aFpnQXlSeGs/view?usp=sharing

## JIRA
[[SPARK-10214] Improve SparkR Column, DataFrame API docs - ASF JIRA](https://issues.apache.org/jira/browse/SPARK-10214)

Author: Yu ISHIKAWA <[email protected]>

Closes #8414 from yu-iskw/SPARK-10214.

(cherry picked from commit d4549fe)
Signed-off-by: Shivaram Venkataraman <[email protected]>
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Aug 25, 2015

Thank you for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants