Skip to content

Conversation

@feynmanliang
Copy link
Contributor

  • Makes SQLImplicits.rddToDataFrameHolder scaladoc consistent with SQLContext.createDataFrame[A <: Product](rdd: RDD[A]) since the former is essentially a wrapper for the latter
  • Clarifies createDataFrame[A <: Product] scaladoc to apply for any RDD[Product], not just case classes

@rxin
Copy link
Contributor

rxin commented Aug 25, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Aug 25, 2015

Test build #41496 has finished for PR 8406 at commit 24d166b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Aug 25, 2015

I've merged this.

@asfgit asfgit closed this in 642c43c Aug 25, 2015
asfgit pushed a commit that referenced this pull request Aug 25, 2015
…Products

 * Makes `SQLImplicits.rddToDataFrameHolder` scaladoc consistent with `SQLContext.createDataFrame[A <: Product](rdd: RDD[A])` since the former is essentially a wrapper for the latter
 * Clarifies `createDataFrame[A <: Product]` scaladoc to apply for any `RDD[Product]`, not just case classes

Author: Feynman Liang <[email protected]>

Closes #8406 from feynmanliang/sql-doc-fixes.

(cherry picked from commit 642c43c)
Signed-off-by: Reynold Xin <[email protected]>
@feynmanliang feynmanliang deleted the sql-doc-fixes branch August 25, 2015 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants