Skip to content

[SPARK-10180] [SQL] JDBCRDD does not process EqualNullSafe filter. #8391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[SPARK-10180] [SQL] JDBCRDD does not process EqualNullSafe filter. #8391

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d167acb
[SPARK-10180] [SQL] JDBCRDD does not process EqualNullSafe filter.
HyukjinKwon Aug 24, 2015
f76021d
[SPARK-10180] [SQL] Rewirte null-safe equality operator as using isnu…
HyukjinKwon Aug 25, 2015
4fe4b06
[SPARK-10180] [SQL] Add some comments and round brackets
HyukjinKwon Aug 25, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,10 @@ private[sql] class JDBCRDD(
*/
private def compileFilter(f: Filter): String = f match {
case EqualTo(attr, value) => s"$attr = ${compileValue(value)}"
// Since the null-safe equality operator is not a standard SQL operator,
// This was written as using is-null and normal equality.
case EqualNullSafe(attr, value) =>
s"($attr = ${compileValue(value)} OR ($attr IS NULL AND ${compileValue(value)} IS NULL))"
Copy link
Contributor

@rxin rxin Sep 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be null if attr is null but value is not null?

Copy link
Member Author

@HyukjinKwon HyukjinKwon Sep 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late comment.
Yes.. it looks so. There can be a problem if the query uses the result of comparison <=>.

Let me correct this soon as (NOT ($attr <> ${compileValue(value)} OR $attr IS NULL OR ${compileValue(value)} IS NULL) OR ($attr IS NULL AND ${compileValue(value)} IS NULL)).

(BTW, I found <=> actually a standard but as IS NOT DISTINCT FROM from SQL1999 but not many DBs look supporting this)

case LessThan(attr, value) => s"$attr < ${compileValue(value)}"
case GreaterThan(attr, value) => s"$attr > ${compileValue(value)}"
case LessThanOrEqual(attr, value) => s"$attr <= ${compileValue(value)}"
Expand Down